mirror of
https://github.com/dehydrated-io/dehydrated.git
synced 2026-01-11 22:30:44 +01:00
missing id #412
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @makuk66 on GitHub (Jun 18, 2019).
When I ran
dehydrated -c(as ofmastertoday) on a new host, I got:Note the lack of account ID at the end of that URL there.
This happens because this code does not verify the parsed
ACCOUNT_IDvalue before using it:74a536c161/dehydrated (L404-L409)and somehow I had a
registration_info.jsonthat contained JSON content, but noidfield, soACCOUNT_IDwas empty. I'm not entirely sure how I got to that state. I had rundehydrated --register --accept-termsand gotten aAccount already registered!. Perhaps this is because I tried to configure Let's Encrypt for this domain from some different machine some time ago.I got passed this by doing
8bae8d28b3ie by treating a missingidfield as if the json file was missing, causing it to fetch it from the CA. I then ended up with anidfield in myregistration_info.json, and certs were successfully created.@elgarfo commented on GitHub (Jun 21, 2019):
i came across the same issue these days and your patch works perfectly. thanks for this quick fix @makuk66!
i only experienced this problem while using the staging v2 api. the production api works just fine. this might have to do with #636.
#650 is another example of this problem (also using the staging environment).
@cpu commented on GitHub (Jun 21, 2019):
@elgarfo You're correct about this. I filed a separate issue (#652) that explains the root cause and the link to the staging environment. This will become an issue for the production endpoint in the next few weeks.