starred/dehydrated
1
0
Fork 0
mirror of https://github.com/dehydrated-io/dehydrated.git synced 2026-07-22 04:48:33 +02:00
Code Issues 79 Packages Projects Releases 10 Wiki Activity

Why was version 1 API removed #404

New Issue
Closed
opened 2025-12-29 01:24:29 +01:00 by adam · 2 comments
adam commented 2025-12-29 01:24:29 +01:00
Owner
Copy Link
Copy Source

Originally created by @mrackers on GitHub (Mar 4, 2019).

We started getting errors 3/3/2019 related to version 1 not supported. We found that you removed that support in the code within the last day. Can you explain why?

Originally created by @mrackers on GitHub (Mar 4, 2019). We started getting errors 3/3/2019 related to version 1 not supported. We found that you removed that support in the code within the last day. Can you explain why?
adam closed this issue 2025-12-29 01:24:29 +01:00
adam commented 2025-12-29 01:24:30 +01:00
Author
Owner
Copy Link
Copy Source

@lukas2511 commented on GitHub (Mar 4, 2019):

This was discussed since quite a while ago, see #510. Main reason being that ACME v1 support always results in a bit more work and less easily readable code. Since ACME v2 has been around (and live) for quite a while now and is to be considered stable and without any drawbacks I didn't see any reason to keep the old protocol around.

If you are using Let's Encrypt infrastructure I'd recommend you change over to the ACME v2 endpoint, if you have a good use-case for keeping ACME v1 please tell me.

@lukas2511 commented on GitHub (Mar 4, 2019): This was discussed since quite a while ago, see #510. Main reason being that ACME v1 support always results in a bit more work and less easily readable code. Since ACME v2 has been around (and live) for quite a while now and is to be considered stable and without any drawbacks I didn't see any reason to keep the old protocol around. If you are using Let's Encrypt infrastructure I'd recommend you change over to the ACME v2 endpoint, if you have a good use-case for keeping ACME v1 please tell me.
adam commented 2025-12-29 01:24:31 +01:00
Author
Owner
Copy Link
Copy Source

@lukas2511 commented on GitHub (Mar 4, 2019):

I was approached by another person telling me that there actually are other CAs out there that implemented v1 and not v2, so I reverted the removal for now and will keep v1 around for as long as there a no major inconveniences supporting it with future changes. I've written a bit about this in the the documentation so it doesn't become a surprise in the future see docs/acme-v1.md.

@lukas2511 commented on GitHub (Mar 4, 2019): I was approached by another person telling me that there actually are other CAs out there that implemented v1 and not v2, so I reverted the removal for now and will keep v1 around for as long as there a no major inconveniences supporting it with future changes. I've written a bit about this in the the documentation so it doesn't become a surprise in the future see [docs/acme-v1.md](https://github.com/lukas2511/dehydrated/blob/74a536c16178312845503caa5322c19de34b2dca/docs/acme-v1.md).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Complicated
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
 suggestions wanted
testing
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dehydrated#404