mirror of
https://github.com/dehydrated-io/dehydrated.git
synced 2026-01-11 22:30:44 +01:00
Why was version 1 API removed #404
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mrackers on GitHub (Mar 4, 2019).
We started getting errors 3/3/2019 related to version 1 not supported. We found that you removed that support in the code within the last day. Can you explain why?
@lukas2511 commented on GitHub (Mar 4, 2019):
This was discussed since quite a while ago, see #510. Main reason being that ACME v1 support always results in a bit more work and less easily readable code. Since ACME v2 has been around (and live) for quite a while now and is to be considered stable and without any drawbacks I didn't see any reason to keep the old protocol around.
If you are using Let's Encrypt infrastructure I'd recommend you change over to the ACME v2 endpoint, if you have a good use-case for keeping ACME v1 please tell me.
@lukas2511 commented on GitHub (Mar 4, 2019):
I was approached by another person telling me that there actually are other CAs out there that implemented v1 and not v2, so I reverted the removal for now and will keep v1 around for as long as there a no major inconveniences supporting it with future changes. I've written a bit about this in the the documentation so it doesn't become a surprise in the future see docs/acme-v1.md.