Please pass domains to startup_hook #379

New Issue

2025-12-29T01:24:02+01:00

adam commented

2025-12-29 01:24:02 +01:00

Originally created by @bzed on GitHub (Oct 2, 2018).

Hi,

it would be great if you could pass all domains to the startup hook like it is done for the other hooks, or add an extra "validate_domains" hook. We need to check if all (customer) configured domains are avtually lvalid before trying to get certificates for them - right now its a script wrapped around dehydrated, but I'd prefer to be able to do this in a hook.

Thanks,

Bernd

Originally created by @bzed on GitHub (Oct 2, 2018). Hi, it would be great if you could pass all domains to the startup hook like it is done for the other hooks, or add an extra "validate_domains" hook. We need to check if all (customer) configured domains are avtually lvalid before trying to get certificates for them - right now its a script wrapped around dehydrated, but I'd prefer to be able to do this in a hook. Thanks, Bernd

adam closed this issue

2025-12-29 01:24:02 +01:00

adam commented

2025-12-29 01:24:03 +01:00

@lukas2511 commented on GitHub (Oct 20, 2018):

Sorry, but I think that you should really validate the customer domains before handing them over to dehydrated.
The way startup_hook currently is implemented there is no way of adding the domains to it and your only move would be to cancel execution anyways, so it's not much better than a wrapper-script, actually even worse as with a wrapper you can use the --domain parameters and do your domain-list-parsing the way you need it.

Also you could set the KEEP_GOING parameter and dehydrated would just continue with the next certificate if there is an issue with domain validation.

@lukas2511 commented on GitHub (Oct 20, 2018): Sorry, but I think that you should really validate the customer domains before handing them over to dehydrated. The way `startup_hook` currently is implemented there is no way of adding the domains to it and your only move would be to cancel execution anyways, so it's not much better than a wrapper-script, actually even worse as with a wrapper you can use the `--domain` parameters and do your domain-list-parsing the way you need it. Also you could set the `KEEP_GOING` parameter and dehydrated would just continue with the next certificate if there is an issue with domain validation.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dehydrated#379