Clean challenge via hook bug? #330

New Issue

adam · 2025-12-29T01:22:49+01:00

adam commented

2025-12-29 01:22:49 +01:00

Originally created by @yarozen on GitHub (Apr 11, 2018).

i'm using the default HOOK_CHAIN="no" as i'm calling the deploy_challenge and clean_challenge function seperatel and in my case i'm using CHALLENGETYPE="http-01".
i notice that the function "clean_challenge" is not being called in such scenario.

i think that after these 2 lines:

      # Clean challenge token using non-chained hook
      [[ "${CHALLENGETYPE}" = "dns-01" ]] && [[ -n "${HOOK}" ]] && [[ "${HOOK_CHAIN}" != "yes" ]] && "${HOOK}" "clean_challenge" ${deploy_args[${idx}]}

some like this line should appear
[[ "${CHALLENGETYPE}" = "http-01" ]] && [[ -n "${HOOK}" ]] && [[ "${HOOK_CHAIN}" != "yes" ]] && "${HOOK}" "clean_challenge" ${deploy_args[${idx}]}

is there a problem or am I missing something?

Originally created by @yarozen on GitHub (Apr 11, 2018). i'm using the default HOOK_CHAIN="no" as i'm calling the deploy_challenge and clean_challenge function seperatel and in my case i'm using CHALLENGETYPE="http-01". i notice that the function "clean_challenge" is not being called in such scenario. i think that after these 2 lines: ``` # Clean challenge token using non-chained hook [[ "${CHALLENGETYPE}" = "dns-01" ]] && [[ -n "${HOOK}" ]] && [[ "${HOOK_CHAIN}" != "yes" ]] && "${HOOK}" "clean_challenge" ${deploy_args[${idx}]} ``` some like this line should appear ` [[ "${CHALLENGETYPE}" = "http-01" ]] && [[ -n "${HOOK}" ]] && [[ "${HOOK_CHAIN}" != "yes" ]] && "${HOOK}" "clean_challenge" ${deploy_args[${idx}]}` is there a problem or am I missing something?

adam closed this issue

2025-12-29 01:22:49 +01:00

adam commented

2025-12-29 01:22:50 +01:00

@lukas2511 commented on GitHub (Apr 13, 2018):

I recently restructured the loop because it left challenges in place after an invalid validation and I mistakenly added a check for dns-01 validations for the hook-call. Removed that check and everything should be fine now.

@lukas2511 commented on GitHub (Apr 13, 2018): I recently restructured the loop because it left challenges in place after an invalid validation and I mistakenly added a check for dns-01 validations for the hook-call. Removed that check and everything should be fine now.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dehydrated#330