Originally created by @txr13 on GitHub (Mar 2, 2018).
While processing a pre-generated CSR, dehydrated generated a private key instead of using the CSR. Upon investigation, I found that my CSR started with
-----BEGIN NEW CERTIFICATE REQUEST-----
instead of
-----BEGIN CERTIFICATE REQUEST-----
which caused dehydrated to believe that the hook hadn't generated a CSR.
Upon investigation, I note that RFC 7468 notes this syntax as "non-conforming" (see Appendix A). Support is indeed not required, but it might be helpful to allow either form of CSR, or at least return a warning about the non-standard syntax. Otherwise, people may wind up confused as to why their CSR isn't being used.
Originally created by @txr13 on GitHub (Mar 2, 2018).
While processing a pre-generated CSR, `dehydrated` generated a private key instead of using the CSR. Upon investigation, I found that my CSR started with
> -----BEGIN NEW CERTIFICATE REQUEST-----
instead of
> -----BEGIN CERTIFICATE REQUEST-----
which caused `dehydrated` to believe that the hook hadn't generated a CSR.
Upon investigation, I note that [RFC 7468](https://tools.ietf.org/html/rfc7468) notes this syntax as "non-conforming" (see Appendix A). Support is indeed not *required*, but it might be helpful to allow either form of CSR, or at least return a warning about the non-standard syntax. Otherwise, people may wind up confused as to why their CSR isn't being used.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Originally created by @txr13 on GitHub (Mar 2, 2018).
While processing a pre-generated CSR,
dehydratedgenerated a private key instead of using the CSR. Upon investigation, I found that my CSR started withinstead of
which caused
dehydratedto believe that the hook hadn't generated a CSR.Upon investigation, I note that RFC 7468 notes this syntax as "non-conforming" (see Appendix A). Support is indeed not required, but it might be helpful to allow either form of CSR, or at least return a warning about the non-standard syntax. Otherwise, people may wind up confused as to why their CSR isn't being used.