mirror of
https://github.com/dehydrated-io/dehydrated.git
synced 2026-06-02 03:50:52 +02:00
request_failure and invalid_challenge not executed when HOOK_CHAIN=yes #263
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jmptbl on GitHub (Nov 16, 2017).
Today I was struggling to setup dns-01 challenges with HOOK_CHAIN=yes. I had a DNS setup problem which would have caused invalid_challenge to run with a useful explanation, but with HOOK_CHAIN=yes it doesn't run. I noticed the same for request_failure.
Having HOOK_CHAIN=yes is optimal for dns-01, since it allows all the challenges for a cert to be bundled into one DNS update.
Culprit lines:
https://github.com/lukas2511/dehydrated/blob/3d97799d6a269a727fb041f60e0b587c273fbe95/dehydrated#L428
https://github.com/lukas2511/dehydrated/blob/3d97799d6a269a727fb041f60e0b587c273fbe95/dehydrated#L623