starred/dehydrated
1
0
Fork 0
mirror of https://github.com/dehydrated-io/dehydrated.git synced 2026-07-21 12:28:33 +02:00
Code Issues 79 Packages Projects Releases 10 Wiki Activity

Wrong default setting #229

New Issue
Closed
opened 2025-12-29 01:19:26 +01:00 by adam · 1 comment
adam commented 2025-12-29 01:19:26 +01:00
Owner
Copy Link
Copy Source

Originally created by @K-Ko on GitHub (Jun 27, 2017).

config.sh says

# Output directory for challenge-tokens to be served by webserver or deployed in HOOK (default: $BASEDIR/.acme-challenges)
#WELLKNOWN=$BASEDIR/.acme-challenges

If I use a custom config file and only change BASEDIR, the default is calculated wrong:

[[ -z "${WELLKNOWN}" ]] && WELLKNOWN="/var/www/dehydrated"

Must be

[[ -z "${WELLKNOWN}" ]] && WELLKNOWN="${BASEDIR}"

So I have to change WELLKNOWN=... also

Originally created by @K-Ko on GitHub (Jun 27, 2017). `config.sh` says # Output directory for challenge-tokens to be served by webserver or deployed in HOOK (default: $BASEDIR/.acme-challenges) #WELLKNOWN=$BASEDIR/.acme-challenges If I use a custom config file and **only** change `BASEDIR`, the default is calculated wrong: [[ -z "${WELLKNOWN}" ]] && WELLKNOWN="/var/www/dehydrated" Must be [[ -z "${WELLKNOWN}" ]] && WELLKNOWN="${BASEDIR}" So I have to change `WELLKNOWN=...` also
adam closed this issue 2025-12-29 01:19:26 +01:00
adam commented 2025-12-29 01:19:27 +01:00
Author
Owner
Copy Link
Copy Source

@lukas2511 commented on GitHub (Jun 27, 2017):

No, that's not an issue, you should never serve challenge files from your BASEDIR! Those files are to be considered very public and you should keep them as far away as possible from your private data.

Also you seem to have an old version of the example config since the new one clearly shows /var/www/dehydrated as default value:

# Output directory for challenge-tokens to be served by webserver or deployed in HOOK (default: /var/www/dehydrated)
#WELLKNOWN="/var/www/dehydrated"
@lukas2511 commented on GitHub (Jun 27, 2017): No, that's not an issue, you should **never** serve challenge files from your BASEDIR! Those files are to be considered **very** public and you should keep them as far away as possible from your private data. Also you seem to have an old version of the example config since the new one clearly shows `/var/www/dehydrated` as default value: ``` # Output directory for challenge-tokens to be served by webserver or deployed in HOOK (default: /var/www/dehydrated) #WELLKNOWN="/var/www/dehydrated" ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Complicated
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
 suggestions wanted
testing
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dehydrated#229