starred/dehydrated
1
0
Fork 0
mirror of https://github.com/dehydrated-io/dehydrated.git synced 2026-01-13 15:13:33 +01:00
Code Issues 79 Packages Projects Releases 10 Wiki Activity

Revoked certificates are not archived #214

New Issue
Closed
opened 2025-12-29 01:19:03 +01:00 by adam · 3 comments
adam commented 2025-12-29 01:19:03 +01:00
Owner
Copy Link

Originally created by @ghost on GitHub (Apr 23, 2017).

The --cleanup command does not move files like "cert-123-pem-revoked" to the archive directory.

Is this by design, or should the cleanup procedure actually move those files as well?

Thank you.

Originally created by @ghost on GitHub (Apr 23, 2017). The --cleanup command does not move files like "cert-123-pem-revoked" to the archive directory. Is this by design, or should the cleanup procedure actually move those files as well? Thank you.
adam closed this issue 2025-12-29 01:19:03 +01:00
adam commented 2025-12-29 01:19:04 +01:00
Author
Owner
Copy Link

@txr13 commented on GitHub (Apr 23, 2017):

This is (as far as I can tell) by design. The cleanup procedure checks the symlinks to determine the current targets, then archives the files of that type that are not currently linked.

I'm going just from memory here, but I believe this procedure doesn't work for revoked files, since they're no longer in the same naming convention as the subroutine checks for.

This is a duplicate of #237. I've been meaning to write some code to address this, but I haven't figured out a good way to archive all revoked certs without touching any other user-created files in the filespace...

@txr13 commented on GitHub (Apr 23, 2017): This is (as far as I can tell) by design. The cleanup procedure checks the symlinks to determine the current targets, then archives the files of that type that are not currently linked. I'm going just from memory here, but I believe this procedure doesn't work for revoked files, since they're no longer in the same naming convention as the subroutine checks for. This is a duplicate of #237. I've been meaning to write some code to address this, but I haven't figured out a good way to archive all revoked certs without touching any other user-created files in the filespace...
adam commented 2025-12-29 01:19:04 +01:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 25, 2017):

It's not a bug, it is a feature :)

Just kidding, I am glad someone is aware of the problem and I am sure it will get sorted out eventually.

@ghost commented on GitHub (Apr 25, 2017): It's not a bug, it is a *feature* :) Just kidding, I am glad someone is aware of the problem and I am sure it will get sorted out eventually.
adam commented 2025-12-29 01:19:05 +01:00
Author
Owner
Copy Link

@lukas2511 commented on GitHub (Jul 10, 2017):

Fixed in dc600e39b8.

@lukas2511 commented on GitHub (Jul 10, 2017): Fixed in dc600e39b8643767bcaa265c0e0ad3039c757073.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Complicated
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
 suggestions wanted
testing
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dehydrated#214
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?