mirror of
https://github.com/dehydrated-io/dehydrated.git
synced 2026-01-11 22:30:44 +01:00
Allow otherNames Aliases #197
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @kermitDerFrosch on GitHub (Feb 17, 2017).
Use this diff to allow signing of working xmpp s2s certs.
others.diff.txt
@lukas2511 commented on GitHub (Jul 10, 2017):
I don't understand, where does this
othername:come from? The only thing I found that mentioned this was for arbitrary data which doesn't really make sense for altnames...@kermitDerFrosch commented on GitHub (Jul 10, 2017):
you need something like this, for correct s2s support
@lukas2511 commented on GitHub (Jul 10, 2017):
This looks like something which would be stripped by Let's Encrypt / Boulder anyway, or is this supported? Have you tried this using a custom csr?
@kermitDerFrosch commented on GitHub (Jul 10, 2017):
Seems like it is supported. I make my xmpp certs with this othername directive and sign them with the pathed version. I never have problems. If I make a cert without it, I get s2s errors from the server.
@lukas2511 commented on GitHub (Jul 11, 2017):
Okay, I merged your changes since they shouldn't interfere with anything else and if that makes dehydrated work for you (and probably a few other people) that's great 😄 Thanks for the suggestion.