starred/dehydrated
1
0
Fork 0
mirror of https://github.com/dehydrated-io/dehydrated.git synced 2026-01-11 22:30:44 +01:00
Code Issues 79 Packages Projects Releases 10 Wiki Activity

"Already validated" failure #172

New Issue
Closed
opened 2025-12-29 00:26:27 +01:00 by adam · 2 comments
adam commented 2025-12-29 00:26:27 +01:00
Owner
Copy Link

Originally created by @BastienDurel on GitHub (Dec 22, 2016).

Hello,

When a challenge is in state "valid", the validation loop is skipped, and variables are not initialized, therefore the script crashes :

# INFO: Using main config file /root/letsencrypt.sh/config
Processing vm1.xxx.fr
 + Signing domains...
 + Creating new directory /root/letsencrypt.sh/certs/vm1.xxx.fr ...
 + Generating private key...
 + Generating signing request...
 + Requesting challenge for vm1.xxx.fr...
 + Already validated
./dehydrated: line 515: deploy_args: unbound variable

commenting the continue at line 476 makes it working, but I'm not sure it's the best solution (but I'm not a bash expert ;))

# INFO: Using main config file /root/letsencrypt.sh/config
Processing vm1.xxx.fr
 + Signing domains...
 + Generating private key...
 + Generating signing request...
 + Requesting challenge for vm1.xxx.fr...
 + Already validated
 + Responding to challenge for vm1.xxx.fr...
 + Challenge is valid!
 + Requesting certificate...
 + Checking certificate...
 + Done!
 + Creating fullchain.pem...
 + Done!
Originally created by @BastienDurel on GitHub (Dec 22, 2016). Hello, When a challenge is in state "valid", the validation loop is skipped, and variables are not initialized, therefore the script crashes : ```root@magento-1:~/letsencrypt.sh# ./dehydrated -c # INFO: Using main config file /root/letsencrypt.sh/config Processing vm1.xxx.fr + Signing domains... + Creating new directory /root/letsencrypt.sh/certs/vm1.xxx.fr ... + Generating private key... + Generating signing request... + Requesting challenge for vm1.xxx.fr... + Already validated ./dehydrated: line 515: deploy_args: unbound variable ``` commenting the `continue` at line 476 makes it working, but I'm not sure it's the best solution (but I'm not a bash expert ;)) ```root@magento-1:~/letsencrypt.sh# ./dehydrated -c # INFO: Using main config file /root/letsencrypt.sh/config Processing vm1.xxx.fr + Signing domains... + Generating private key... + Generating signing request... + Requesting challenge for vm1.xxx.fr... + Already validated + Responding to challenge for vm1.xxx.fr... + Challenge is valid! + Requesting certificate... + Checking certificate... + Done! + Creating fullchain.pem... + Done! ```
adam closed this issue 2025-12-29 00:26:27 +01:00
adam commented 2025-12-29 00:26:28 +01:00
Author
Owner
Copy Link

@lukas2511 commented on GitHub (Dec 22, 2016):

Commenting the "continue" line would completely disable the feature to skip already validated domains, I'm working on a fix right now.

@lukas2511 commented on GitHub (Dec 22, 2016): Commenting the "continue" line would completely disable the feature to skip already validated domains, I'm working on a fix right now.
adam commented 2025-12-29 00:26:28 +01:00
Author
Owner
Copy Link

@BastienDurel commented on GitHub (Dec 22, 2016):

I know this is disabling the functionality, It was not a proposed fix, only a workaround info

@BastienDurel commented on GitHub (Dec 22, 2016): I know this is disabling the functionality, It was not a proposed fix, only a workaround info
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Complicated
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
 suggestions wanted
testing
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dehydrated#172
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?