mirror of
https://github.com/dehydrated-io/dehydrated.git
synced 2026-01-11 22:30:44 +01:00
Do not hard code subscriber agreement URL #130
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rolandshoemaker on GitHub (Aug 1, 2016).
Boulder provides the current subscriber Agreement in a
Linkheader of the typeterms-of-servicein response to a valid/acme/new-regPOST request, this should be used instead of hard coding the most recent URL.Continuing to hard code the URL will cause consistent failures for anyone trying to create a new registration whenever Let's Encrypt chooses to update their agreement.
@Celti commented on GitHub (Aug 1, 2016):
AFAIK, the reason for the current “hard-coding” (it's not hard-coded, it's a variable adjustable in the config file) is that that in theory provides a fool-proof method of demonstrating you agree with the current terms of service.
I don't think it should be automatically drawn from the headers — but perhaps it would be smart for letsencrypt.sh to include logic that informs you “The terms of service have updated; here is the link to the Subscriber Agreement. Please update your configuration to agree with the new terms.”
@pcfreak30 commented on GitHub (Aug 3, 2016):
Just added support for this in vestacp.
You can use the following command to get the agreement url
agreement=$(curl -s -I "$api/terms" |grep Location |cut -f 2 -d \ |tr -d '\r\n')with$apibeingapi='https://acme-v01.api.letsencrypt.org'@lukas2511 commented on GitHub (Jan 29, 2017):
Closing in favor of #346, thanks for your hints.