json response issue #110

New Issue

adam · 2025-12-29T00:25:06+01:00

adam commented

2025-12-29 00:25:06 +01:00

Originally created by @connaryscott on GitHub (May 27, 2016).

We are using your client in our TLS automation, on line #426 the following change was made since this client just began to fail on 26 May 2016:

+    #challenges="$(printf '%s\n' "${response}" | sed -n 's/.*\("challenges":[^\[]*\[[^]]*]\).*/\1/p')"
+    challenges="$(printf '%s\n' "${response}" | tr -d '\n' |sed -n 's/.*\("challenges":[^\[]*\[[^]]*]\).*/\1/p')"

Notice that we needed to delete all newlines in the json response. Perhaps the response is now pretty format as opposed to a single line?

Originally created by @connaryscott on GitHub (May 27, 2016). We are using your client in our TLS automation, on line #426 the following change was made since this client just began to fail on 26 May 2016: ``` + #challenges="$(printf '%s\n' "${response}" | sed -n 's/.*$"challenges":[^\[]*\[[^]]*]$.*/\1/p')" + challenges="$(printf '%s\n' "${response}" | tr -d '\n' |sed -n 's/.*$"challenges":[^\[]*\[[^]]*]$.*/\1/p')" ``` Notice that we needed to delete all newlines in the json response. Perhaps the response is now pretty format as opposed to a single line?

adam closed this issue

2025-12-29 00:25:06 +01:00

adam commented

2025-12-29 00:25:06 +01:00

@lukas2511 commented on GitHub (May 27, 2016):

You also could just have downloaded the newest version which also includes a similar change. Thanks anyway.

@lukas2511 commented on GitHub (May 27, 2016): You also could just have downloaded the newest version which also includes a similar change. Thanks anyway.

adam commented

2025-12-29 00:25:07 +01:00

@connaryscott commented on GitHub (May 28, 2016):

ok thanks did not realize that. appreciate the response.

On Fri, May 27, 2016 at 1:37 PM, Lukas Schauer notifications@github.com
wrote:

You also could just have downloaded the newest version which also includes
a similar change. Thanks anyway.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lukas2511/letsencrypt.sh/issues/213#issuecomment-222247353,
or mute the thread
https://github.com/notifications/unsubscribe/AAi4OS6WcKqzW0jRRRdqaIKqaPUEJz7Iks5qF1X1gaJpZM4IoqQH
.

@connaryscott commented on GitHub (May 28, 2016): ok thanks did not realize that. appreciate the response. On Fri, May 27, 2016 at 1:37 PM, Lukas Schauer notifications@github.com wrote: > You also could just have downloaded the newest version which also includes > a similar change. Thanks anyway. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > https://github.com/lukas2511/letsencrypt.sh/issues/213#issuecomment-222247353, > or mute the thread > https://github.com/notifications/unsubscribe/AAi4OS6WcKqzW0jRRRdqaIKqaPUEJz7Iks5qF1X1gaJpZM4IoqQH > .

adam referenced this issue

2025-12-29 01:28:38 +01:00

[PR #110] [CLOSED] read domains into temporary file and array to allow stdin to function… #717

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dehydrated#110