[PR #59] [MERGED] rails timezone support #92

New Issue

adam · 2025-12-29T00:22:32+01:00

adam commented

2025-12-29 00:22:32 +01:00

📋 Pull Request Information

Original PR: https://github.com/plashchynski/crono/pull/59
Author: @0xRichardH
Created: 2/28/2017
Status: ✅ Merged
Merged: 3/10/2017
Merged by: @plashchynski

Base: master ← Head: master

📝 Commits (2)

258052b ✨ rails timezone support
d72a2d2 write some annotation

📊 Changes

7 files changed (+36 additions, -32 deletions)

View changed files

📝 lib/crono/cli.rb (+2 -2)
📝 lib/crono/job.rb (+5 -5)
📝 lib/crono/period.rb (+4 -4)
📝 lib/crono/time_of_day.rb (+2 -2)
📝 spec/job_spec.rb (+2 -2)
📝 spec/period_spec.rb (+17 -17)
📝 spec/spec_helper.rb (+4 -0)

📄 Description

I think in Rails way, Crono timezone should not dependent on system timezone , it should dependent Rails project time zone.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/plashchynski/crono/pull/59 **Author:** [@0xRichardH](https://github.com/0xRichardH) **Created:** 2/28/2017 **Status:** ✅ Merged **Merged:** 3/10/2017 **Merged by:** [@plashchynski](https://github.com/plashchynski) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`258052b`](https://github.com/plashchynski/crono/commit/258052b852398f9239633a891d14b16325f4ec6e) :sparkles: rails timezone support - [`d72a2d2`](https://github.com/plashchynski/crono/commit/d72a2d2b07c7f7c5dd0a739a95adce14d879274c) write some annotation ### 📊 Changes **7 files changed** (+36 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `lib/crono/cli.rb` (+2 -2) 📝 `lib/crono/job.rb` (+5 -5) 📝 `lib/crono/period.rb` (+4 -4) 📝 `lib/crono/time_of_day.rb` (+2 -2) 📝 `spec/job_spec.rb` (+2 -2) 📝 `spec/period_spec.rb` (+17 -17) 📝 `spec/spec_helper.rb` (+4 -0) </details> ### 📄 Description I think in Rails way, Crono timezone should not dependent on system timezone , it should dependent Rails project time zone. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 00:22:32 +01:00

adam closed this issue

2025-12-29 00:22:32 +01:00

adam referenced this issue

2025-12-29 00:22:36 +01:00

[PR #92] [MERGED] Rake example does only fire once #101

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/crono#92