mirror of
https://github.com/plashchynski/crono.git
synced 2026-01-13 13:53:27 +01:00
[PR #37] [MERGED] add start stop and restart to cli #86
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/plashchynski/crono/pull/37
Author: @jannishuebl
Created: 1/15/2016
Status: ✅ Merged
Merged: 1/16/2016
Merged by: @plashchynski
Base:
master← Head:jhuebl_add_start_stop_and_restart_to_cli_20160114📝 Commits (3)
0affff2add start|stop|restart|run to crono executable4a0c2d7add documentation and fix --help5d9b420fix build and config_spec📊 Changes
8 files changed (+171 additions, -25 deletions)
View changed files
📝
Gemfile.lock(+2 -3)📝
README.md(+5 -4)📝
crono.gemspec(+1 -0)📝
lib/crono/cli.rb(+63 -11)📝
lib/crono/config.rb(+15 -2)➕
log/.keep(+0 -0)📝
spec/cli_spec.rb(+70 -2)📝
spec/config_spec.rb(+15 -3)📄 Description
Hey,
I add more functionality to the CLI, know there is the possibility to stop and restart the daemon.
The old Interface can be still used without changes. If the user want to use the new functionality the user has to include the daemon gem to the Rails project. This gem is used by delayed_job so the user might have it as dependency anyway.
But still he is not forced to use crono with daemon-gem. The current way is still working.
I needed to add a restart strategy for one of our use cases.
Feel free to commend on my changes. I will also test my changes in production in the next weeks.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.