[PR #37] [MERGED] add start stop and restart to cli #86

Closed
opened 2025-12-29 00:22:28 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/plashchynski/crono/pull/37
Author: @jannishuebl
Created: 1/15/2016
Status: Merged
Merged: 1/16/2016
Merged by: @plashchynski

Base: masterHead: jhuebl_add_start_stop_and_restart_to_cli_20160114


📝 Commits (3)

  • 0affff2 add start|stop|restart|run to crono executable
  • 4a0c2d7 add documentation and fix --help
  • 5d9b420 fix build and config_spec

📊 Changes

8 files changed (+171 additions, -25 deletions)

View changed files

📝 Gemfile.lock (+2 -3)
📝 README.md (+5 -4)
📝 crono.gemspec (+1 -0)
📝 lib/crono/cli.rb (+63 -11)
📝 lib/crono/config.rb (+15 -2)
log/.keep (+0 -0)
📝 spec/cli_spec.rb (+70 -2)
📝 spec/config_spec.rb (+15 -3)

📄 Description

Hey,

I add more functionality to the CLI, know there is the possibility to stop and restart the daemon.
The old Interface can be still used without changes. If the user want to use the new functionality the user has to include the daemon gem to the Rails project. This gem is used by delayed_job so the user might have it as dependency anyway.

But still he is not forced to use crono with daemon-gem. The current way is still working.

I needed to add a restart strategy for one of our use cases.

Feel free to commend on my changes. I will also test my changes in production in the next weeks.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/plashchynski/crono/pull/37 **Author:** [@jannishuebl](https://github.com/jannishuebl) **Created:** 1/15/2016 **Status:** ✅ Merged **Merged:** 1/16/2016 **Merged by:** [@plashchynski](https://github.com/plashchynski) **Base:** `master` ← **Head:** `jhuebl_add_start_stop_and_restart_to_cli_20160114` --- ### 📝 Commits (3) - [`0affff2`](https://github.com/plashchynski/crono/commit/0affff21d13a74d91f511003bdd560d8cf7e960b) add start|stop|restart|run to crono executable - [`4a0c2d7`](https://github.com/plashchynski/crono/commit/4a0c2d78e24bd1b1f5c3b4b27a9c5f3d6aebcbe2) add documentation and fix --help - [`5d9b420`](https://github.com/plashchynski/crono/commit/5d9b420582329740c3eab868a5c2d2d6f3b3fca9) fix build and config_spec ### 📊 Changes **8 files changed** (+171 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `Gemfile.lock` (+2 -3) 📝 `README.md` (+5 -4) 📝 `crono.gemspec` (+1 -0) 📝 `lib/crono/cli.rb` (+63 -11) 📝 `lib/crono/config.rb` (+15 -2) ➕ `log/.keep` (+0 -0) 📝 `spec/cli_spec.rb` (+70 -2) 📝 `spec/config_spec.rb` (+15 -3) </details> ### 📄 Description Hey, I add more functionality to the CLI, know there is the possibility to stop and restart the daemon. The old Interface can be still used without changes. If the user want to use the new functionality the user has to include the [daemon](https://github.com/thuehlinger/daemons) gem to the Rails project. This gem is used by delayed_job so the user might have it as dependency anyway. But still he is not forced to use crono with daemon-gem. The current way is still working. I needed to add a restart strategy for one of our use cases. Feel free to commend on my changes. I will also test my changes in production in the next weeks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 00:22:28 +01:00
adam closed this issue 2025-12-29 00:22:28 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/crono#86