[PR #127] [MERGED] Add Rails 7.2 support #128

New Issue

adam · 2025-12-29T00:22:51+01:00

adam commented

2025-12-29 00:22:51 +01:00

📋 Pull Request Information

Original PR: https://github.com/plashchynski/crono/pull/127
Author: @janko
Created: 8/19/2024
Status: ✅ Merged
Merged: 8/19/2024
Merged by: @plashchynski

Base: main ← Head: rails-7.2

📝 Commits (2)

9a8e804 Add Propshaft for tests
ab4e1e8 Call clear_active_connections! on the connection handler

📊 Changes

3 files changed (+177 additions, -140 deletions)

View changed files

📝 Gemfile.lock (+175 -139)
📝 crono.gemspec (+1 -0)
📝 lib/crono/job.rb (+1 -1)

📄 Description

This avoids calling ActiveRecord::Base.clear_active_connections!, which has been removed in Rails 7.2. AFAICT this has always been a delegator to the connection handler, so this should be compatible with older Active Record versions as well.

I needed to update some gems to make things work, as well as add Propshaft after https://github.com/plashchynski/crono/pull/123, since specs wouldn't run without an asset pipeline.

Closes #126

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/plashchynski/crono/pull/127 **Author:** [@janko](https://github.com/janko) **Created:** 8/19/2024 **Status:** ✅ Merged **Merged:** 8/19/2024 **Merged by:** [@plashchynski](https://github.com/plashchynski) **Base:** `main` ← **Head:** `rails-7.2` --- ### 📝 Commits (2) - [`9a8e804`](https://github.com/plashchynski/crono/commit/9a8e8049f9687bb49a93dac26bc636c318b24ed7) Add Propshaft for tests - [`ab4e1e8`](https://github.com/plashchynski/crono/commit/ab4e1e808d1a042a311525c5cfd0fc409d62f625) Call `clear_active_connections!` on the connection handler ### 📊 Changes **3 files changed** (+177 additions, -140 deletions) <details> <summary>View changed files</summary> 📝 `Gemfile.lock` (+175 -139) 📝 `crono.gemspec` (+1 -0) 📝 `lib/crono/job.rb` (+1 -1) </details> ### 📄 Description This avoids calling `ActiveRecord::Base.clear_active_connections!`, which has been removed in Rails 7.2. AFAICT this has always been a delegator to the connection handler, so this should be compatible with older Active Record versions as well. I needed to update some gems to make things work, as well as add Propshaft after https://github.com/plashchynski/crono/pull/123, since specs wouldn't run without an asset pipeline. Closes #126 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 00:22:51 +01:00

adam closed this issue

2025-12-29 00:22:52 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/crono#128