Though this method was likely never meant to take user input, it was
attempting sanitization. That sanitization could be bypassed with
carefully crafted input.
This commit makes the sanitization more robust by replacing any
occurrances of "/" or "/" with "/ " or " /". It also performs a
first pass to remove one surrounding comment to avoid compatibility
issues for users relying on the existing removal.
This also clarifies in the documentation of annotate that it should not
be provided user input.
[CVE-2023-22794]
Added integer width check to PostgreSQL::Quoting
Given a value outside the range for a 64bit signed integer type
PostgreSQL will treat the column type as numeric. Comparing
integer values against numeric values can result in a slow
sequential scan.
This behavior is configurable via
ActiveRecord::Base.raise_int_wider_than_64bit which defaults to true.
Redis cache store is now compatible with redis-rb 5.0.
Jean Boussier
Fix NoMethodError on custom ActiveSupport::Deprecation behavior.
ActiveSupport::Deprecation.behavior= was supposed to accept any object
that responds to call, but in fact its internal implementation assumed that
this object could respond to arity, so it was restricted to only Proc objects.
This change removes this arity restriction of custom behaviors.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot use these labels will set the current labels as the default for future PRs for this repo and language
@dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
@dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
@dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the Security Alerts page.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/plashchynski/crono/pull/116
**Author:** [@dependabot[bot]](https://github.com/apps/dependabot)
**Created:** 1/18/2023
**Status:** 🔄 Open
**Base:** `main` ← **Head:** `dependabot/bundler/activesupport-7.0.4.1`
---
### 📝 Commits (1)
- [`a26afa4`](https://github.com/plashchynski/crono/commit/a26afa4e197179cf389d4f9b01546a99cc3ba136) Bump activesupport from 7.0.3.1 to 7.0.4.1
### 📊 Changes
**1 file changed** (+65 additions, -65 deletions)
<details>
<summary>View changed files</summary>
📝 `Gemfile.lock` (+65 -65)
</details>
### 📄 Description
Bumps [activesupport](https://github.com/rails/rails) from 7.0.3.1 to 7.0.4.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/rails/rails/releases">activesupport's releases</a>.</em></p>
<blockquote>
<h2>v7.0.4.1</h2>
<p>This is a security release. More information is available in our security announcements forum: <a href="https://discuss.rubyonrails.org/c/security-announcements/9">https://discuss.rubyonrails.org/c/security-announcements/9</a></p>
<h2>Active Support</h2>
<ul>
<li>
<p>Avoid regex backtracking in Inflector.underscore</p>
<p>[CVE-2023-22796]</p>
</li>
</ul>
<h2>Active Model</h2>
<ul>
<li>No changes.</li>
</ul>
<h2>Active Record</h2>
<ul>
<li>
<p>Make sanitize_as_sql_comment more strict</p>
<p>Though this method was likely never meant to take user input, it was
attempting sanitization. That sanitization could be bypassed with
carefully crafted input.</p>
<p>This commit makes the sanitization more robust by replacing any
occurrances of "/<em>" or "</em>/" with "/ <em>" or "</em> /". It also performs a
first pass to remove one surrounding comment to avoid compatibility
issues for users relying on the existing removal.</p>
<p>This also clarifies in the documentation of annotate that it should not
be provided user input.</p>
<p>[CVE-2023-22794]</p>
</li>
<li>
<p>Added integer width check to PostgreSQL::Quoting</p>
<p>Given a value outside the range for a 64bit signed integer type
PostgreSQL will treat the column type as numeric. Comparing
integer values against numeric values can result in a slow
sequential scan.</p>
<p>This behavior is configurable via
ActiveRecord::Base.raise_int_wider_than_64bit which defaults to true.</p>
<p>[CVE-2022-44566]</p>
</li>
</ul>
<h2>Action View</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/rails/rails/blob/v7.0.4.1/activesupport/CHANGELOG.md">activesupport's changelog</a>.</em></p>
<blockquote>
<h2>Rails 7.0.4.1 (January 17, 2023)</h2>
<ul>
<li>
<p>Avoid regex backtracking in Inflector.underscore</p>
<p>[CVE-2023-22796]</p>
</li>
</ul>
<h2>Rails 7.0.4 (September 09, 2022)</h2>
<ul>
<li>
<p>Redis cache store is now compatible with redis-rb 5.0.</p>
<p><em>Jean Boussier</em></p>
</li>
<li>
<p>Fix <code>NoMethodError</code> on custom <code>ActiveSupport::Deprecation</code> behavior.</p>
<p><code>ActiveSupport::Deprecation.behavior=</code> was supposed to accept any object
that responds to <code>call</code>, but in fact its internal implementation assumed that
this object could respond to <code>arity</code>, so it was restricted to only <code>Proc</code> objects.</p>
<p>This change removes this <code>arity</code> restriction of custom behaviors.</p>
<p><em>Ryo Nakamura</em></p>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/rails/rails/commit/23e0345fe900dfd7edd6e8e5a7a6bd54b2a7d2ed"><code>23e0345</code></a> Version 7.0.4.1</li>
<li><a href="https://github.com/rails/rails/commit/2164d4f6a1bde74b911fe9ba3c8df1b5bf345bf8"><code>2164d4f</code></a> Avoid regex backtracking in Inflector.underscore</li>
<li><a href="https://github.com/rails/rails/commit/8015c2c2cf5c8718449677570f372ceb01318a32"><code>8015c2c</code></a> Version 7.0.4</li>
<li><a href="https://github.com/rails/rails/commit/ff277583e22ddfbcfbd2131789a7cb7c2f868d68"><code>ff27758</code></a> Revert "Merge pull request <a href="https://github-redirect.dependabot.com/rails/rails/issues/44695">#44695</a> from Edouard-chin/ec-tagger-logger-broadcast"</li>
<li><a href="https://github.com/rails/rails/commit/4a1f22474bde75f74093547223937f4b6516b077"><code>4a1f224</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rails/rails/issues/45882">#45882</a> from rails/short-inspect-on-test-case</li>
<li><a href="https://github.com/rails/rails/commit/a3bd3b5ec6448db4f7f30771a2b1aa519b6c21e9"><code>a3bd3b5</code></a> Backport Redis 5.0 compatibility</li>
<li><a href="https://github.com/rails/rails/commit/67f37acc3a8660e15448b7f764fdb12eaba6fec2"><code>67f37ac</code></a> Fix flaky tests for RedisCacheStore</li>
<li><a href="https://github.com/rails/rails/commit/c520e3872e4d70d3ecab0576531947cea8c80e5f"><code>c520e38</code></a> Document AS::Cache::MemCacheStore#write options [ci-skip]</li>
<li><a href="https://github.com/rails/rails/commit/a74b650f3632fc9b60b9364398ba0183aaede23f"><code>a74b650</code></a> Document AS::Cache::Store#initialize options [ci-skip]</li>
<li><a href="https://github.com/rails/rails/commit/f7a82bf5465eab1c3556f1204c15788930935da8"><code>f7a82bf</code></a> Document AS::Cache::Store#read options [ci-skip]</li>
<li>Additional commits viewable in <a href="https://github.com/rails/rails/compare/v7.0.3.1...v7.0.4.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/plashchynski/crono/network/alerts).
</details>
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/plashchynski/crono/pull/116
Author: @dependabot[bot]
Created: 1/18/2023
Status: 🔄 Open
Base:
main← Head:dependabot/bundler/activesupport-7.0.4.1📝 Commits (1)
a26afa4Bump activesupport from 7.0.3.1 to 7.0.4.1📊 Changes
1 file changed (+65 additions, -65 deletions)
View changed files
📝
Gemfile.lock(+65 -65)📄 Description
Bumps activesupport from 7.0.3.1 to 7.0.4.1.
Release notes
Sourced from activesupport's releases.
... (truncated)
Changelog
Sourced from activesupport's changelog.
Commits
23e0345Version 7.0.4.12164d4fAvoid regex backtracking in Inflector.underscore8015c2cVersion 7.0.4ff27758Revert "Merge pull request #44695 from Edouard-chin/ec-tagger-logger-broadcast"4a1f224Merge pull request #45882 from rails/short-inspect-on-test-casea3bd3b5Backport Redis 5.0 compatibility67f37acFix flaky tests for RedisCacheStorec520e38Document AS::Cache::MemCacheStore#write options [ci-skip]a74b650Document AS::Cache::Store#initialize options [ci-skip]f7a82bfDocument AS::Cache::Store#read options [ci-skip]Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.