[PR #91] [MERGED] Convert to Rails engine #100

New Issue

adam · 2025-12-29T00:22:36+01:00

adam commented

2025-12-29 00:22:36 +01:00

📋 Pull Request Information

Original PR: https://github.com/plashchynski/crono/pull/91
Author: @cseelus
Created: 2/14/2021
Status: ✅ Merged
Merged: 5/29/2022
Merged by: @plashchynski

Base: master ← Head: convert-to-engine-rspec

📝 Commits (5)

d53520b Use Rails plugin generator and adapt
551572f Move CronoJob to models dir
6fee31f Fix tests
ee79596 Cleanup and get rspec to run again
333f18d Merge branch 'master' into convert-to-engine-rspec

📊 Changes

76 files changed (+775 additions, -1420 deletions)

View changed files

📝 .rspec (+1 -0)
📝 Changes.md (+8 -0)
📝 Gemfile (+21 -1)
📝 Gemfile.lock (+161 -3)
📝 README.md (+5 -11)
📝 Rakefile (+3 -4)
➕ app/assets/javascripts/crono/materialize.min.js (+6 -0)
➕ app/assets/stylesheets/crono/application.css (+26 -0)
➕ app/assets/stylesheets/crono/materialize.min.css (+31 -0)
➕ app/controllers/crono/application_controller.rb (+5 -0)
➕ app/controllers/crono/jobs_controller.rb (+11 -0)
➕ app/models/crono/application_record.rb (+5 -0)
📝 app/models/crono/crono_job.rb (+1 -2)
➕ app/views/crono/jobs/index.html.erb (+50 -0)
➕ app/views/crono/jobs/show.html.erb (+16 -0)
➕ app/views/layouts/crono/application.html.erb (+31 -0)
➕ bin/rails (+24 -0)
➕ config.ru (+9 -0)
➕ config/routes.rb (+4 -0)
📝 crono.gemspec (+5 -6)

...and 56 more files

📄 Description

First, thanks for this gem. Been using it since ~5 years and it works really reliably.

This PR converts Crono to a Rails Engine. Sinatra (and Haml) are not needed as dependencies for the Web UI anymore.

It also updates Materialize CSS and overhauls the Web UI to make it responsive and display properly on mobile devices:

Before:

After:

After (alternative w/o tables, in different branch):

All tests are green again. A bit of cleanup that I still could do, should this PR be a direction you want to go.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/plashchynski/crono/pull/91 **Author:** [@cseelus](https://github.com/cseelus) **Created:** 2/14/2021 **Status:** ✅ Merged **Merged:** 5/29/2022 **Merged by:** [@plashchynski](https://github.com/plashchynski) **Base:** `master` ← **Head:** `convert-to-engine-rspec` --- ### 📝 Commits (5) - [`d53520b`](https://github.com/plashchynski/crono/commit/d53520bbf093958ced6413345a6d2fee21f68c63) Use Rails plugin generator and adapt - [`551572f`](https://github.com/plashchynski/crono/commit/551572fe5626313502208e6f6f78f00cbe5d7ec3) Move CronoJob to models dir - [`6fee31f`](https://github.com/plashchynski/crono/commit/6fee31fc8149e2d1b93874d9a33b4f0619ef4006) Fix tests - [`ee79596`](https://github.com/plashchynski/crono/commit/ee79596509574ff37c508efe447fa949ad4d22a6) Cleanup and get rspec to run again - [`333f18d`](https://github.com/plashchynski/crono/commit/333f18d89b96a05ea1df9e774a342b5f281eac05) Merge branch 'master' into convert-to-engine-rspec ### 📊 Changes **76 files changed** (+775 additions, -1420 deletions) <details> <summary>View changed files</summary> 📝 `.rspec` (+1 -0) 📝 `Changes.md` (+8 -0) 📝 `Gemfile` (+21 -1) 📝 `Gemfile.lock` (+161 -3) 📝 `README.md` (+5 -11) 📝 `Rakefile` (+3 -4) ➕ `app/assets/javascripts/crono/materialize.min.js` (+6 -0) ➕ `app/assets/stylesheets/crono/application.css` (+26 -0) ➕ `app/assets/stylesheets/crono/materialize.min.css` (+31 -0) ➕ `app/controllers/crono/application_controller.rb` (+5 -0) ➕ `app/controllers/crono/jobs_controller.rb` (+11 -0) ➕ `app/models/crono/application_record.rb` (+5 -0) 📝 `app/models/crono/crono_job.rb` (+1 -2) ➕ `app/views/crono/jobs/index.html.erb` (+50 -0) ➕ `app/views/crono/jobs/show.html.erb` (+16 -0) ➕ `app/views/layouts/crono/application.html.erb` (+31 -0) ➕ `bin/rails` (+24 -0) ➕ `config.ru` (+9 -0) ➕ `config/routes.rb` (+4 -0) 📝 `crono.gemspec` (+5 -6) _...and 56 more files_ </details> ### 📄 Description First, thanks for this gem. Been using it since ~5 years and it works really reliably. This PR converts Crono to a [Rails Engine](https://guides.rubyonrails.org/v4.1.1/engines.html#what-are-engines-questionmark). Sinatra (and Haml) are not needed as dependencies for the Web UI anymore. It also updates Materialize CSS and overhauls the Web UI to make it responsive and display properly on mobile devices: Before: <img width="373" alt="Screen Shot 2021-02-14 at 17 52 05" src="https://user-images.githubusercontent.com/3188392/107883229-fa440b80-6eed-11eb-879d-d4cca5d2da37.png"> After: <img width="372" alt="Screen Shot 2021-02-14 at 17 55 35" src="https://user-images.githubusercontent.com/3188392/107883232-ffa15600-6eed-11eb-810e-d8587970f948.png"> After (alternative w/o tables, in different branch): <img width="375" alt="Screen Shot 2021-02-14 at 17 56 00" src="https://user-images.githubusercontent.com/3188392/107883241-10ea6280-6eee-11eb-93cf-81220c2163df.png"> All tests are green again. A bit of cleanup that I still could do, should this PR be a direction you want to go. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 00:22:36 +01:00

adam closed this issue

2025-12-29 00:22:37 +01:00

adam referenced this issue

2025-12-29 00:22:39 +01:00

[PR #100] [CLOSED] Bump nokogiri from 1.11.1 to 1.13.6 #107

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/crono#100