From 0b19ddfda0646742189b303b246f787b29a41d9a Mon Sep 17 00:00:00 2001 From: Ryan Blunden Date: Mon, 19 Apr 2021 13:09:41 +1000 Subject: [PATCH 1/5] Add link checker --- .github/workflows/link-checker.yml | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 .github/workflows/link-checker.yml diff --git a/.github/workflows/link-checker.yml b/.github/workflows/link-checker.yml new file mode 100644 index 0000000..b5ce627 --- /dev/null +++ b/.github/workflows/link-checker.yml @@ -0,0 +1,8 @@ +name: Markdown link checker +on: [push,pull_request,workflow_dispatch] +jobs: + markdown-link-check: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@master + - uses: gaurav-nelson/github-action-markdown-link-check@v1 From 681e688a9bce3efcf9fd252a2e7879ba1d57ae25 Mon Sep 17 00:00:00 2001 From: Ryan Blunden Date: Mon, 19 Apr 2021 13:21:32 +1000 Subject: [PATCH 2/5] Removed broken links --- README.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/README.md b/README.md index 5f6c79c..a540b5f 100644 --- a/README.md +++ b/README.md @@ -448,7 +448,6 @@ Please read the [contribution guidelines](contributing.md) or [creating a list g * [A list of Frequently Asked Questions and their answers, sorted by category](http://www.scala-lang.org/old/faq) * [A list of helpful Scala related questions you can use to interview potential candidates](https://github.com/Jarlakxen/Scala-Interview-Questions) * [How Scala Developers Are Being Interviewed](http://programmers.stackexchange.com/questions/58145/how-scala-developers-are-being-interviewed) -* [Scala Interview Questions/Answers including Language Questions, Functional Programming Questions, Reactive Programming Questions](https://github.com/peterarsentev/Scala-Interview-Questions-Answers) * [Top 25 Scala Interview Questions & Answers from Toptal](http://career.guru99.com/top-25-interview-questions-on-scala/) ### SharePoint @@ -558,7 +557,6 @@ Please read the [contribution guidelines](contributing.md) or [creating a list g * [10 Useful Random Linux Interview Questions and Answers](http://www.tecmint.com/useful-random-linux-interview-questions-and-answers/) * [11 Basic Linux Interview Questions and Answers](http://www.tecmint.com/basic-linux-interview-questions-and-answers/) * [11 Essential Linux Interview Questions from Toptal](http://www.toptal.com/linux/interview-questions) -* [Some basic Linux questions from ComputerNetworkingNotes.com](http://computernetworkingnotes.com/rhce-interview-questions/linux-interview-questions-answers.html) * [Top 30 Linux System Admin Interview Questions & Answers](http://www.linuxtechi.com/experience-linux-admin-interview-questions/) * [Top 50 Linux Interview Questions from Career Guru](http://career.guru99.com/top-50-linux-interview-questions/) * [278 Test Questions and Answers for \*nix System Administrators](https://github.com/trimstray/test-your-sysadmin-skills) @@ -581,7 +579,6 @@ Please read the [contribution guidelines](contributing.md) or [creating a list g * [A great list of Java interview questions](http://java2novice.com/java-interview-programs/) * [Algorithms playground for common interview questions written in Ruby](https://github.com/sagivo/algorithms) * [EKAlgorithms contains some well known CS algorithms & data structures](https://github.com/EvgenyKarkan/EKAlgorithms) -* [Five programming problems every Software Engineer should be able to solve in less than 1 hour](http://www.shiftedup.com/2015/05/07/five-programming-problems-every-software-engineer-should-be-able-to-solve-in-less-than-1-hour) * [Top 10 Algorithms for Coding Interview](http://www.programcreek.com/2012/11/top-10-algorithms-for-coding-interview/) * [Top 15 Data Structures and Algorithm Interview Questions for Java programmer](http://javarevisited.blogspot.com.by/2013/03/top-15-data-structures-algorithm-interview-questions-answers-java-programming.html) * [Top Algorithms Questions by Topics](https://github.com/yangshun/tech-interview-handbook/blob/master/algorithms/README.md) From fefee0f18cb917c3178f83f78f084c1cd22d6747 Mon Sep 17 00:00:00 2001 From: Ryan Blunden Date: Mon, 19 Apr 2021 13:22:55 +1000 Subject: [PATCH 3/5] Run on request only as many broken links were false negatives --- .github/workflows/link-checker.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/link-checker.yml b/.github/workflows/link-checker.yml index b5ce627..695cf56 100644 --- a/.github/workflows/link-checker.yml +++ b/.github/workflows/link-checker.yml @@ -1,5 +1,5 @@ name: Markdown link checker -on: [push,pull_request,workflow_dispatch] +on: [workflow_dispatch] jobs: markdown-link-check: runs-on: ubuntu-latest From b7bf9c09d775c196a7f74f0dbd0cb85248d06e26 Mon Sep 17 00:00:00 2001 From: Ryan Blunden Date: Mon, 19 Apr 2021 13:32:25 +1000 Subject: [PATCH 4/5] Try ignoring non-broken links --- .github/workflows/link-checker.yml | 9 ++++-- .github/workflows/mlc_config.json | 44 ++++++++++++++++++++++++++++++ 2 files changed, 50 insertions(+), 3 deletions(-) create mode 100644 .github/workflows/mlc_config.json diff --git a/.github/workflows/link-checker.yml b/.github/workflows/link-checker.yml index 695cf56..8924865 100644 --- a/.github/workflows/link-checker.yml +++ b/.github/workflows/link-checker.yml @@ -1,8 +1,11 @@ name: Markdown link checker -on: [workflow_dispatch] +on: [push,pull_request,workflow_dispatch] jobs: markdown-link-check: runs-on: ubuntu-latest steps: - - uses: actions/checkout@master - - uses: gaurav-nelson/github-action-markdown-link-check@v1 + - uses: actions/checkout@master + - uses: gaurav-nelson/github-action-markdown-link-check@v1 + with: + config-file: '.github/workflows/mlc_config.json' + diff --git a/.github/workflows/mlc_config.json b/.github/workflows/mlc_config.json new file mode 100644 index 0000000..4b12d83 --- /dev/null +++ b/.github/workflows/mlc_config.json @@ -0,0 +1,44 @@ +{ + "ignorePatterns": [ + { + "pattern": "https://adevait.com/android/interview-questions" + }, + { + "pattern": "https://www.fullstack.cafe/blog/docker-interview-questions-and-answers" + }, + { + "pattern": "https://www.fullstack.cafe/blog/5-graphql-interview-questions-you-should-know" + }, + { + "pattern": "https://adevait.com/ios/interview-questions" + }, + { + "pattern": "https://adevait.com/java/interview-questions" + }, + { + "pattern": "https://adevait.com/javascript-developers/interview-questions" + }, + { + "pattern": "https://adevait.com/nodejs/interview-questions" + }, + { + "pattern": "https://adevait.com/php/interview-questions" + }, + { + "pattern": "https://adevait.com/python/interview-questions" + }, + { + "pattern": "https://danielmiessler.com/study/infosec_interview_questions/" + }, + { + "pattern": "https://www.datacamp.com/community/news/top-100-data-science-interview-questions-cc3lts7gj5j" + } + ], + "timeout": "5s", + "retryCount": 3, + "fallbackRetryDelay": "10s", + "aliveStatusCodes": [ + 200, + 206 + ] +} From df5ed0cb63f5264012350013080dc02123ca66b4 Mon Sep 17 00:00:00 2001 From: Ryan Blunden Date: Mon, 19 Apr 2021 13:43:43 +1000 Subject: [PATCH 5/5] Fix broken image links --- .github/workflows/link-checker.yml | 2 +- contributing.md | 16 +++++----------- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/.github/workflows/link-checker.yml b/.github/workflows/link-checker.yml index 8924865..4048d04 100644 --- a/.github/workflows/link-checker.yml +++ b/.github/workflows/link-checker.yml @@ -1,5 +1,5 @@ name: Markdown link checker -on: [push,pull_request,workflow_dispatch] +on: [pull_request,workflow_dispatch] jobs: markdown-link-check: runs-on: ubuntu-latest diff --git a/contributing.md b/contributing.md index 803bec0..fde114e 100644 --- a/contributing.md +++ b/contributing.md @@ -35,14 +35,8 @@ If you have something awesome to contribute to an awesome list, this is how you You'll need a [GitHub account](https://github.com/join)! 1. Access the awesome lists GitHub page. For example: https://github.com/MaximAbramchuck/awesome-interviews -2. Click on the `README.md` file: ![Step 2 Click on Readme.md](https://leto34g.storage.yandex.net/rdisk/8948449e1d73cd0dcfef07f186b7a36e2f7f20d96790c13e852332d0463f7bfb/inf/7e5phO26eyQewxB0SXXAytng0o1HQ9hHVNdV9di4FeXYEPGQzRqXznc9UrAF_Rah2Ux7fSJqVWwPgOLkbBKExA==?uid=0&filename=2015-11-28%2013-28-41%20MaximAbramchuck%20awesome-interviews.png&disposition=inline&hash=&limit=0&content_type=image%2Fpng&tknv=v2&rtoken=7cb5689a2bde8e7a302bcb7c55b41c7c&force_default=no&ycrid=na-f270d9f138679e558b06ec1ec93034d7-downloader10e) -3. Now click on the edit icon. ![Step 3 - Click on Edit](https://leto29d.storage.yandex.net/rdisk/05fa06697433943f9203b0653fb0c800f8bf15690ba4d2e8efcd435dc3b8934b/inf/KIRmm9wzFRC95NHeDkZNaNHvzSktU7_HosUvbdi0WdjOVYACD2iNhCZLoJuOXyUo2ykJrzKiBnSlkBRWi1FQIQ==?uid=0&filename=2015-11-28%2013-29-56%20awesome-interviews%20README.md%20at%20master%20%C2%B7%20MaximAbramchuck%20awesome-interviews.png&disposition=inline&hash=&limit=0&content_type=image%2Fpng&tknv=v2&rtoken=7cb5689a2bde8e7a302bcb7c55b41c7c&force_default=no&ycrid=na-2c689dfbfd6867ddba96f0b10b4ba3bf-downloader10e) -4. You can start editing the text of the file in the in-browser editor. Make sure you follow guidelines above. You can use [GitHub Flavored Markdown](https://help.github.com/articles/github-flavored-markdown/). ![Step 4 - Edit the file](https://leto2f.storage.yandex.net/rdisk/0101ae04ba3a6d2e36f8fec8fd66929bce822ac477828c9d9af97e9fbf24b4cb/inf/n_E0tlZ5u0HYaW2S1k6W1nTYNnR-DKS78m3QtdFbkTzcjSj0Y-rzN10vrGMs85gbrez8mFR3TRJcMWTuPN3F-A==?uid=0&filename=2015-11-28%2013-31-20%20Editing%20awesome-interviews%20README.md%20at%20master%20%C2%B7%20MaximAbramchuck%20awesome-interviews.png&disposition=inline&hash=&limit=0&content_type=image%2Fpng&tknv=v2&rtoken=7cb5689a2bde8e7a302bcb7c55b41c7c&force_default=no&ycrid=na-0c11edf2ab8448c3bc9b221e3139c857-downloader10e) -5. Say why you're proposing the changes, and then click on "Propose file change". ![Step 5 - Propose Changes](https://leto30e.storage.yandex.net/rdisk/4ed220e31e45076c75274f6e428bfc577638d13ed51d781ee6911b9febd3d7c6/inf/oj_OaawPZ0980PXZqNTB5mTW3H7w2j9sPvnFUGsN6VvM69LS7jLsXgxNyyWJqGmJ5y4JYyO9LZSNkjyNEeYrEA==?uid=0&filename=2015-11-28%2013-31-59%20Editing%20awesome-interviews%20README.md%20at%20master%20%C2%B7%20MaximAbramchuck%20awesome-interviews.png&disposition=inline&hash=&limit=0&content_type=image%2Fpng&tknv=v2&rtoken=7cb5689a2bde8e7a302bcb7c55b41c7c&force_default=no&ycrid=na-7239d00ed9e5460b3946af9c615345f3-downloader10e) -6. Submit the [pull request](https://help.github.com/articles/using-pull-requests/)! - -## Updating your Pull Request - -Sometimes, a maintainer of an awesome list will ask you to edit your Pull Request before it is included. This is normally due to spelling errors or because your PR didn't match the awesome-* list guidelines. - -[Here](https://github.com/RichardLitt/docs/blob/master/amending-a-commit-guide.md) is a write up on how to change a Pull Request, and the different ways you can do that. +2. Click on the `README.md` file +3. Now click on the edit icon +4. Edit contents of the file using the in-browser editor to add your changes +5. Explain why you're proposing your changes, then click "Propose file change". +6. Submit the [pull request](https://help.github.com/articles/using-pull-requests/)