starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[Enhancement] Support podcast episode Pub Date without specifying time #964

New Issue
Open
opened 2026-04-24 23:27:51 +02:00 by adam · 2 comments
adam commented 2026-04-24 23:27:51 +02:00
Owner
Copy Link
Copy Source

Originally created by @apiweb on GitHub (Feb 19, 2023).

Describe the issue

When I try to edit a podcast episode. If I don't input a time on the Pub Date field, the form is submitted with a null PubDate value.
Some episodes I don't hour the hour date, but the ABS required a time when I try to edit a podcast file.
If I input only the date info, my request is sent with a null/empty value as PubDate.

image

Steps to reproduce the issue

  1. Edit a podcast episode
  2. Click on the pub date and insert only the date
  3. Save the episode
  4. The pub date is saved as null

This happens if you are using the tab key to jump between the inputs
When you insert a date (typing, not choosing by the calendar component), if you press the tab key, the form will jump to the Title field, just with the Date inserted on the PubDate field.
And if you try to save just the date, a null value is sent instead of the Date only.

ErrorOnTheRequest

Audiobookshelf version

v2.2.15

How are you running audiobookshelf?

Docker

Originally created by @apiweb on GitHub (Feb 19, 2023). ### Describe the issue When I try to edit a podcast episode. If I don't input a time on the Pub Date field, the form is submitted with a null PubDate value. Some episodes I don't hour the hour date, but the ABS required a time when I try to edit a podcast file. If I input only the date info, my request is sent with a null/empty value as PubDate. ![image](https://user-images.githubusercontent.com/5881027/219977127-db5f6acc-08bb-4a96-98d7-06c89def65a2.png) ### Steps to reproduce the issue 1. Edit a podcast episode 2. Click on the pub date and insert only the date 3. Save the episode 4. The pub date is saved as null This happens if you are using the tab key to jump between the inputs When you insert a date (typing, not choosing by the calendar component), if you press the tab key, the form will jump to the Title field, just with the Date inserted on the PubDate field. And if you try to save just the date, a null value is sent instead of the Date only. <img width="409" alt="ErrorOnTheRequest" src="https://user-images.githubusercontent.com/5881027/219977510-af0af0cd-4b88-42ee-892a-7c8c72b77f19.png"> ### Audiobookshelf version v2.2.15 ### How are you running audiobookshelf? Docker
adam added the enhancement label 2026-04-24 23:27:51 +02:00
adam commented 2026-04-24 23:27:52 +02:00
Author
Owner
Copy Link
Copy Source

@chrishoage commented on GitHub (Jan 6, 2025):

To me this is a data loss bug. The form should be in an "invalid" state and not let you save at the very least.

I just spent a lot of time filling out podcast details not knowing I was not saving my work.

Edit: My suggestion of disallowing the form submission when the date is invalid was completed in #3805

@chrishoage commented on GitHub (Jan 6, 2025): To me this is a data loss bug. The form should be in an "invalid" state and not let you save at the very least. I just spent a lot of time filling out podcast details not knowing I was not saving my work. Edit: My suggestion of disallowing the form submission when the date is invalid was completed in #3805
adam commented 2026-04-24 23:27:53 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (Jan 7, 2025):

The next release will include an error message preventing submission and a red border showing the date is invalid. It won't support leaving the time blank so I'll leave this open.

The issue with leaving the time blank is that we are using the browsers native datetime input by passing datetime-local in the type attribute of the HTML input. When the date and time is either incomplete or invalid the value is left empty on the input.

For example, if you type "25/01/2015" and leave the time blank there is no way (that I know of) to get the "25/01/2015". We have to build a custom input to support that.

I wrote a bit more about that here https://github.com/advplyr/audiobookshelf/pull/3805#issuecomment-2576172888

@advplyr commented on GitHub (Jan 7, 2025): The next release will include an error message preventing submission and a red border showing the date is invalid. It won't support leaving the time blank so I'll leave this open. The issue with leaving the time blank is that we are using the browsers native datetime input by passing `datetime-local` in the type attribute of the HTML input. When the date and time is either incomplete or invalid the value is left empty on the input. For example, if you type "25/01/2015" and leave the time blank there is no way (that I know of) to get the "25/01/2015". We have to build a custom input to support that. I wrote a bit more about that here https://github.com/advplyr/audiobookshelf/pull/3805#issuecomment-2576172888
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#964
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?