mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Bug]: Missing Translation Strings #758
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#758
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tomazed on GitHub (Nov 16, 2022).
Describe the issue
After doing the French translation, I've noticed several strings that were not in the json files
The missing labels (highlighted in yellow) are found in Book Edit => Tools
The "or" in upload page
The Apprise Label in the Settings => Notifications page
Steps to reproduce the issue
Audiobookshelf version
2.2.4
How are you running audiobookshelf?
Built from source
@advplyr commented on GitHub (Nov 17, 2022):
Thanks, I'm sure there will be a bunch of these.
I also added some Socket strings.
@burghy86 commented on GitHub (Nov 18, 2022):
other missing traslation
@tomazed commented on GitHub (Nov 18, 2022):
Found some more in the metadata manager=>M4B Encoder
metadata manager =>Embedded Metadata
Some label of thoses two pages overlap
@advplyr commented on GitHub (Nov 18, 2022):
The sort/filter ones are added but I didn't add the tooltip because that won't be staying for much longer.
@advplyr commented on GitHub (Nov 19, 2022):
I also had a bunch of strings out of order, they were supposed to be alphabetical.
@tomazed commented on GitHub (Nov 19, 2022):
when searching for strings, I found a lot of hardcoded strings in client/components/app/LazyBookshelf.vue for example
https://github.com/advplyr/audiobookshelf/blob/30cf144090117b18dc979b91d9d361f7950a4384/client/components/app/LazyBookshelf.vue#L88-L89
lots of them seems to be related to default configuration or empty library. The only one I'm seeing in my setup is "You haven't made any collections yet" and this file is the only file that match this string
@advplyr commented on GitHub (Nov 19, 2022):
I got all of these except the ones on the tools page you mentioned here https://github.com/advplyr/audiobookshelf/issues/1166#issuecomment-1320605264
These are in v2.2.5
@burghy86 commented on GitHub (Nov 20, 2022):
@advplyr commented on GitHub (Nov 20, 2022):
The first 3 screenshots were added already. I'm not sure about the shortened days of the week/month since those need to be that size to work with the design.
@burghy86 commented on GitHub (Nov 20, 2022):
The screenshot arrive with 2.2.5 release in series and library page
The short day and months is not problem. I reduced with 3 letter
Day: lun mar mer gio ven sab dom
Months: gen Feb mar apr mag giu lug ago set ott nov dic
@advplyr commented on GitHub (Nov 21, 2022):
I think I got most of these. Still need to do the tools page and the week/month short strings.
@tomazed commented on GitHub (Nov 21, 2022):
Some new strings were introduced in commit https://github.com/advplyr/audiobookshelf/commit/3316394f5caa5a8b4e1e55d899256bd9235f2fb7 regarding #1159 . Thoses are not part of the translated strings
https://github.com/advplyr/audiobookshelf/blob/51070b3e7be0e4008612dd82521788b3e2c70cdf/client/components/app/BookShelfToolbar.vue#L64
https://github.com/advplyr/audiobookshelf/blob/51070b3e7be0e4008612dd82521788b3e2c70cdf/client/components/app/BookShelfToolbar.vue#L248-L254
@Hallo951 commented on GitHub (Nov 21, 2022):
Here is another string that is missing.
@advplyr commented on GitHub (Nov 28, 2022):
Still need to get to some of these here so I'll keep this open. Also added a few more in v2.2.6
https://github.com/advplyr/audiobookshelf/commit/c72609013c0a9ba7bcaa3559ab1c7eec781df115
@advplyr commented on GitHub (Nov 28, 2022):
I realized that some of the library filters would be broken when using another language
@advplyr commented on GitHub (Dec 4, 2022):
I had a typo here
It used to say
User square book covers@tomazed commented on GitHub (Dec 6, 2022):
Apparently I did not translate the typo. Label seemed weird to me so I search it in the app I decided it should be "use" instead of "user" and translated accordingly.
no update necessary on the fr.json file ;)
@advplyr Are there any strings left untranslated or can I close the issue?
@advplyr commented on GitHub (Dec 14, 2022):
I just added the "Map details" and 2 other new translations on that page.
I also haven't done the translations for the stats heatmap
@tomazed commented on GitHub (Dec 19, 2022):
Question @advplyr I've been translating the item word to a generic word (Article in French) as I do not know if it's used for something other than audiobooks. Is it used for Podcasts for example? (I think so but I have none to test)
I am really not pleased with this particular translation. Any other fellow french people around here who would have a more suitable translation? I'm also not a fan of objet so I'm really lost (in translation lol) here 🤣
@advplyr commented on GitHub (Dec 19, 2022):
I suppose it depends on the context which I know can be difficult to ascertain from the translation files.
A "Library Item" is a book or podcast. A "Media Item" is a book or podcast episode.
The reason a media item is distinguished is because this is where actual progress is stored. So for podcasts we want to store progress on the episode.
Most of the time "Item" will be referring to Library Item.
For example, "No Items" is referring to Library Item's.
If you point out a specific translation I can tell you more.
@Hallo951 commented on GitHub (Dec 19, 2022):
I have translated "item" into German as "audiobook/podcast".
@advplyr commented on GitHub (Dec 19, 2022):
We will support other media in the future so if there is a generic term for "media" then that would be more fitting.
@advplyr commented on GitHub (Feb 1, 2023):
I think we can close this after v2.2.13
Thanks for all your help in translations and thanks @tomazed for localizing the date/time strings.