mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
Admin user has no access to settings #70
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#70
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Maximilian85 on GitHub (Oct 24, 2021).
Admin user has no access to settings
root User
Admin User have no access
@advplyr commented on GitHub (Oct 24, 2021):
This was intentional to have only root able to access config page, but I set that up when the config page was only one page with a few settings.
How do you think admin should work? Are there any things that admin users shouldn't have access to?
@Jdiesel87 commented on GitHub (Oct 25, 2021):
In my opinion root and admin users should be one in the same. In fact I would prefer to see the default root user removed completely, or have the option to delete it, and manage the server from the admin account. This is how Plex, Emby, Jellyfin are setup.
@advplyr commented on GitHub (Oct 25, 2021):
If you can change the username of root then what is the benefit of being able to remove it?
It can be changed to function that way, but I don't really see the benefit. That would just mean I have to add an extra check to ensure at least 1 admin user is there.
If admin and root work the same, then like linux you could setup an admin account and not use root.
@Jdiesel87 commented on GitHub (Oct 25, 2021):
Being able to change the name of root would suffice and eliminate the need to be able to remove it. I agree that the option to remove the default account would only add complexity and headaches.
In my current use case I use root as my daily driver account as it allows me access to everything I want without having to log in/out. Changing the username of the root account would be a nice option, there are probably some security benefits too.
@advplyr commented on GitHub (Oct 25, 2021):
You can already change the username of root. Maybe this is the only thing that should be unavailable to admin accounts..
So from this thread what is left to do is to allow admin accounts to access config.
@Jdiesel87 commented on GitHub (Oct 25, 2021):
Ahh ok I see it now. I was trying to edit it from the profile screen and the option was greyed out.
It can be edited from the user management screen though.
Is this by design?
@advplyr commented on GitHub (Oct 25, 2021):
It is, but not something I thought a lot about. Would you want your users to be able to change their username?
@Jdiesel87 commented on GitHub (Oct 25, 2021):
No probably not
Current implementation works for me. I was just coming at it from a narrow mindset and didn't explore things enough.
@Maximilian85 commented on GitHub (Oct 25, 2021):
You're right, it fits and the implementation can stay that way. Thanks
@advplyr commented on GitHub (May 4, 2022):
Admin user now has full access in v2.0.10