mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Enhancement]: Ignore punctuation marks (and titles) in Author names #643
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#643
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @raviwarrier on GitHub (Sep 17, 2022).
Describe the feature/enhancement
As you can see from the above image, the only difference between the two Burton G. Malkiels is the period after the 'G', making them displayed as two different authors.
While this is metadata taken from other sources and is no fault of ABS, we can at least ignore the punctuation marks and match the name. Also, it would be nice if we could ignore titles (Dr., etc.) or suffixes (PhD, MD, etc.) at the same time.
@raviwarrier commented on GitHub (Sep 17, 2022):
This I agree is a trickier problem and probably doesn't warrant writing hundreds of lines of code to match & merge.
@advplyr commented on GitHub (Sep 17, 2022):
I think your second example and the prefixes/suffixes you mentioned would be included in #908. I think the solution is to include alternative names for authors.
I think we can have the scanner automatically handle the punctuation case
@raviwarrier commented on GitHub (Sep 17, 2022):
Yes #908 is pretty much the same thing.
Thanks for considering the other use case.
@advplyr commented on GitHub (Oct 2, 2022):
Updated in v2.2.0
@JakobTischler commented on GitHub (Oct 5, 2022):
Version: 2.2.0
I'm not 100% certain this is caused by the commit linked above, but I have some punctuation stripped from the artist in ABS, even though the file tag has it included. This leads to author mismatches.
Example: I have an .m4b file with the artist (and album artist) being
C. J. Box. The file is parsed (and displayed) asC. J Box(notice the missing dot after the J) though.@advplyr commented on GitHub (Oct 5, 2022):
The commit above isn't modifying anything it is only comparing the author parsed from your library item with all other existing authors. That comparison is removing punctuation.
You may have another author already in your library with
C. J Boxand it is matching with that one.@JakobTischler commented on GitHub (Oct 6, 2022):
Nope, definitively no other author with that name. The only thing I can think of is that the folder name is
Box, C. J(given that folders can't have a trailing dot on Windows).@advplyr commented on GitHub (Oct 6, 2022):
Yeah that is exactly what it is then. There is no good way around that trailing dot on windows other then just naming your author folder
C. J. Boxinstead of doing last, first.@JakobTischler commented on GitHub (Oct 8, 2022):
Sure, but why is the folder name relevant at all? I have
Prefer audio metadataturned on in the settings.@advplyr commented on GitHub (Oct 8, 2022):
Are you storing a
metadata.absfile inside your library item folder? That file will override everything and maybe the author name was set in there before you enabled prefer audio metadata.@JakobTischler commented on GitHub (Oct 9, 2022):
No, no .abs files. These are freshly added audiobooks with only the .m4b file.
By the way, it did work correctly before (with v2.1.5).