mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Bug]: Ampersand symbol not parsed correctly in description #598
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#598
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Jdiesel87 on GitHub (Aug 22, 2022).
Describe the issue
I'm not sure if this is a metadata source issue, I'm using the Audible provider, or a ABS issue but the ampersand symbol is being displayed as "& a m p ;" in the description.
Steps to reproduce the issue
Using the Audible provider search the book "I'm Glad My Mom Died" by Jennette McCurdy. The description will contain "& a m p ;" where it should be &
Audiobookshelf version
v2.1.4
How are you running audiobookshelf?
Docker
@barrycarey commented on GitHub (Aug 29, 2022):
@advplyr This is coming from here
The process of stripping the tags also escapes certain characters (&, <, >, "). It doesn't appear there's a config option to sanitizeHtml that would prevent this. Something would have to be implemented to decode the HTML escapes.
@advplyr commented on GitHub (Aug 29, 2022):
@barrycarey ah okay. We can edit the sanitizeHtml library and just manually put in & and any obvious ones.
@barrycarey commented on GitHub (Aug 29, 2022):
Any issues with me adding a function to restore the common characters? Seems like that is the safer solution since the core lib won't be touched.
@advplyr commented on GitHub (Aug 30, 2022):
@barrycarey That's probably better actually, you could put that inside the
htmlSanitizer.jsutil script.@barrycarey commented on GitHub (Aug 30, 2022):
@advplyr What do you think about adding another dependency? This would work
If not, I can still do a generic function to hit the most common html entities.
Let me know which route you'd rather take and I'll submit a PR
@advplyr commented on GitHub (Aug 30, 2022):
I want to avoid adding another dependency unless we have to. That library looks great though we can definitely use these mappings of HTML5 entities they put together.
We only need probably 5% of what that library offers so it ends up being a ton of extra code we don't use.
This only needs to be implemented in that
stripAllTagsfunction because that is expecting a plain text response, whereas thesanitizefunction returns HTML that will render the & correctly. You probably already caught that but just wanted to make sure.@advplyr commented on GitHub (Sep 5, 2022):
Fixed in v2.1.5