starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[Bug]: Library filter for Finished does not work #447

New Issue
Closed
opened 2026-04-24 23:09:39 +02:00 by adam · 4 comments
adam commented 2026-04-24 23:09:39 +02:00
Owner
Copy Link
Copy Source

Originally created by @jmt-gh on GitHub (Jun 8, 2022).

Describe the issue

Applying the finished filter in the library view results in showing nothing

[2022-06-08T04:40:50.659Z] DEBUG: [DB] Updated user: 1 | Selected: 1
TypeError: Cannot read properties of undefined (reading 'isFinished')
    at /git/audiobookshelf/server/utils/libraryHelpers.js:35:75
    at Array.filter (<anonymous>)
    at Object.getFilteredLibraryItems (git/audiobookshelf/server/utils/libraryHelpers.js:31:29)
    at ApiRouter.getLibraryItems git/audiobookshelf/server/controllers/LibraryController.js:166:37)
    at Layer.handle [as handle_request] (git/audiobookshelf/node_modules/express/lib/router/layer.js:95:5)
    at next (git/audiobookshelf/node_modules/express/lib/router/route.js:144:13)
    at ApiRouter.middleware (git/audiobookshelf/server/controllers/LibraryController.js:501:5)
    at Layer.handle [as handle_request] (git/audiobookshelf/node_modules/express/lib/router/layer.js:95:5)
    at next (git/audiobookshelf/node_modules/express/lib/router/route.js:144:13)
    at Route.dispatch (0git/audiobookshelf/node_modules/express/lib/router/route.js:114:3)

Steps to reproduce the issue

  1. set finshed on a book
  2. go to library view
  3. filter for finished

Audiobookshelf version

v2.0.19

How are you running audiobookshelf?

Docker

Originally created by @jmt-gh on GitHub (Jun 8, 2022). ### Describe the issue Applying the finished filter in the library view results in showing nothing ``` [2022-06-08T04:40:50.659Z] DEBUG: [DB] Updated user: 1 | Selected: 1 TypeError: Cannot read properties of undefined (reading 'isFinished') at /git/audiobookshelf/server/utils/libraryHelpers.js:35:75 at Array.filter (<anonymous>) at Object.getFilteredLibraryItems (git/audiobookshelf/server/utils/libraryHelpers.js:31:29) at ApiRouter.getLibraryItems git/audiobookshelf/server/controllers/LibraryController.js:166:37) at Layer.handle [as handle_request] (git/audiobookshelf/node_modules/express/lib/router/layer.js:95:5) at next (git/audiobookshelf/node_modules/express/lib/router/route.js:144:13) at ApiRouter.middleware (git/audiobookshelf/server/controllers/LibraryController.js:501:5) at Layer.handle [as handle_request] (git/audiobookshelf/node_modules/express/lib/router/layer.js:95:5) at next (git/audiobookshelf/node_modules/express/lib/router/route.js:144:13) at Route.dispatch (0git/audiobookshelf/node_modules/express/lib/router/route.js:114:3) ``` ### Steps to reproduce the issue 1. set finshed on a book 2. go to library view 3. filter for finished ### Audiobookshelf version v2.0.19 ### How are you running audiobookshelf? Docker
adam added the bug label 2026-04-24 23:09:39 +02:00
adam closed this issue 2026-04-24 23:09:40 +02:00
adam commented 2026-04-24 23:09:41 +02:00
Author
Owner
Copy Link
Copy Source

@jmt-gh commented on GitHub (Jun 8, 2022):

the offending commit:

https://github.com/advplyr/audiobookshelf/commit/0d1ff35c5ec05bcb73cd6fbf43abe8df062e397e

@jmt-gh commented on GitHub (Jun 8, 2022): the offending commit: https://github.com/advplyr/audiobookshelf/commit/0d1ff35c5ec05bcb73cd6fbf43abe8df062e397e
adam commented 2026-04-24 23:09:41 +02:00
Author
Owner
Copy Link
Copy Source

@jmt-gh commented on GitHub (Jun 8, 2022):

Didn't realize this was fixed here. woops

https://github.com/advplyr/audiobookshelf/commit/881baa818d483055b632269ff485e1f14aed5749

@jmt-gh commented on GitHub (Jun 8, 2022): Didn't realize this was fixed here. woops https://github.com/advplyr/audiobookshelf/commit/881baa818d483055b632269ff485e1f14aed5749
adam commented 2026-04-24 23:09:41 +02:00
Author
Owner
Copy Link
Copy Source

@DieselTech commented on GitHub (Jun 9, 2022):

This bug is still around in v2.0.20

TypeError: Cannot read properties of undefined (reading 'isFinished')
    at /server/utils/libraryHelpers.js:35:75
    at Array.filter (<anonymous>)
    at Object.getFilteredLibraryItems (/server/utils/libraryHelpers.js:31:29)
    at ApiRouter.getLibraryItems (/server/controllers/LibraryController.js:166:37)
    at Layer.handle [as handle_request] (/node_modules/express/lib/router/layer.js:95:5)
    at next (/node_modules/express/lib/router/route.js:144:13)
    at ApiRouter.middleware (/server/controllers/LibraryController.js:501:5)
    at Route.dispatch (/node_modules/express/lib/router/route.js:114:3)

It's also hard to "find" the logs because they aren't being written to files as per #706

@DieselTech commented on GitHub (Jun 9, 2022): This bug is still around in v2.0.20 ``` TypeError: Cannot read properties of undefined (reading 'isFinished') at /server/utils/libraryHelpers.js:35:75 at Array.filter (<anonymous>) at Object.getFilteredLibraryItems (/server/utils/libraryHelpers.js:31:29) at ApiRouter.getLibraryItems (/server/controllers/LibraryController.js:166:37) at Layer.handle [as handle_request] (/node_modules/express/lib/router/layer.js:95:5) at next (/node_modules/express/lib/router/route.js:144:13) at ApiRouter.middleware (/server/controllers/LibraryController.js:501:5) at Route.dispatch (/node_modules/express/lib/router/route.js:114:3) ``` It's also hard to "find" the logs because they aren't being written to files as per #706
adam commented 2026-04-24 23:09:41 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (Jun 9, 2022):

That bug was fixed after the 2.0.20 release, so will be in 2.0.21

@advplyr commented on GitHub (Jun 9, 2022): That bug was fixed after the 2.0.20 release, so will be in 2.0.21
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#447
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?