starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #5183] Draft: Added initial usage of parserDate #4457

New Issue
Open
opened 2026-04-25 00:50:52 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:50:52 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/5183
Author: @shinspiegel
Created: 4/13/2026
Status: 🔄 Open

Base: master ← Head: master

📝 Commits (3)

  • 0b3fd53 Added initial usage of parserDate
  • 30f1c9c Added check for date in extract metadata
  • 6f19bb1 Added date and pubDate for AudioFileScanner

📊 Changes

4 files changed (+188 additions, -4 deletions)

View changed files

📝 server/scanner/AudioFileScanner.js (+8 -3)
➕ server/utils/parsers/parseDate.js (+54 -0)
📝 server/utils/podcastUtils.js (+17 -1)
➕ test/server/utils/parsers/parseDate.test.js (+109 -0)

📄 Description

Brief summary

For my use case, AudiobookShelf is my podcast central, and the Podcast entry is a mp3 file downloaded from other sources (Youtube, SoundCloud...) these files receive the date in the date metadata, with the format of YYYYMMDD. Right now the parser uses a plain new Date() which fails since this isn't a ISO standard.

This should use a parserDate to also attempt to parse these dates.

Which issue is fixed?

Fixes #5192

In-depth Description

On the AudioFileScanner I'm using the newly created parseDate to parse the date from these edge cases.

How have you tested this?

Unit tested and manual tested.

Test Images

Screenshot 2026-04-15 at 08 59 29 Screenshot 2026-04-15 at 09 30 27

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/5183 **Author:** [@shinspiegel](https://github.com/shinspiegel) **Created:** 4/13/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`0b3fd53`](https://github.com/advplyr/audiobookshelf/commit/0b3fd53681b62d11d699406a40986ad4c75e106b) Added initial usage of `parserDate` - [`30f1c9c`](https://github.com/advplyr/audiobookshelf/commit/30f1c9c2524af63c7117031f5a53dec56795ce3a) Added check for date in extract metadata - [`6f19bb1`](https://github.com/advplyr/audiobookshelf/commit/6f19bb1e0cf47ae5bf35397f06038cad3fb9fb55) Added `date` and `pubDate` for AudioFileScanner ### 📊 Changes **4 files changed** (+188 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `server/scanner/AudioFileScanner.js` (+8 -3) ➕ `server/utils/parsers/parseDate.js` (+54 -0) 📝 `server/utils/podcastUtils.js` (+17 -1) ➕ `test/server/utils/parsers/parseDate.test.js` (+109 -0) </details> ### 📄 Description ## Brief summary For my use case, AudiobookShelf is my podcast central, and the Podcast entry is a mp3 file downloaded from other sources (Youtube, SoundCloud...) these files receive the date in the `date` metadata, with the format of `YYYYMMDD`. Right now the parser uses a plain `new Date()` which fails since this isn't a ISO standard. This should use a `parserDate` to also attempt to parse these dates. ## Which issue is fixed? Fixes #5192 ## In-depth Description On the `AudioFileScanner` I'm using the newly created `parseDate` to parse the date from these edge cases. ## How have you tested this? Unit tested and manual tested. ## Test Images <img width="342" height="153" alt="Screenshot 2026-04-15 at 08 59 29" src="https://github.com/user-attachments/assets/ddcb52af-3c1e-40fe-b245-6e3442db4698" /> <img width="320" height="306" alt="Screenshot 2026-04-15 at 09 30 27" src="https://github.com/user-attachments/assets/f1eca91c-3f61-4119-8972-ee656d71fbfd" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:50:52 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4457
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?