starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #5160] [MERGED] Fix item_removed payload to include libraryId #4449

New Issue
Closed
opened 2026-04-25 00:19:47 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:47 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/5160
Author: @mikiher
Created: 3/31/2026
Status: ✅ Merged
Merged: 3/31/2026
Merged by: @advplyr

Base: master ← Head: fix-item-removed-payload

📝 Commits (1)

  • fda1a6e Fix item_removed payload to include libraryId

📊 Changes

3 files changed (+9 additions, -7 deletions)

View changed files

📝 server/controllers/LibraryController.js (+3 -3)
📝 server/controllers/LibraryItemController.js (+2 -2)
📝 server/routers/ApiRouter.js (+4 -2)

📄 Description

Brief summary

Up until now, item_remolved was emitted with just the library item's id as payload. This makes it impossible to ignore the event if the client receiving the event is not displaying the same library as the item's.

Which issue is fixed?

No issue.

In-depth Description

To fix the issue, the libraryId is added to the item_removed payload. This has no effect on existing clients since it just adds to the payload, not changing existing fields.

How have you tested this?

Removed library item on one window. Made sure that library item is still properly removed from the library page in a different window.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/5160 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 3/31/2026 **Status:** ✅ Merged **Merged:** 3/31/2026 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix-item-removed-payload` --- ### 📝 Commits (1) - [`fda1a6e`](https://github.com/advplyr/audiobookshelf/commit/fda1a6ea9bac122b3b84e742f244e2c6eb6c660b) Fix item_removed payload to include libraryId ### 📊 Changes **3 files changed** (+9 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `server/controllers/LibraryController.js` (+3 -3) 📝 `server/controllers/LibraryItemController.js` (+2 -2) 📝 `server/routers/ApiRouter.js` (+4 -2) </details> ### 📄 Description ## Brief summary Up until now, item_remolved was emitted with just the library item's id as payload. This makes it impossible to ignore the event if the client receiving the event is not displaying the same library as the item's. ## Which issue is fixed? No issue. ## In-depth Description To fix the issue, the libraryId is added to the item_removed payload. This has no effect on existing clients since it just adds to the payload, not changing existing fields. ## How have you tested this? Removed library item on one window. Made sure that library item is still properly removed from the library page in a different window. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:47 +02:00
adam closed this issue 2026-04-25 00:19:47 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4449
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?