starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #5097] [CLOSED] Fix author duplication - add optional chaining #5037 #4423

New Issue
Closed
opened 2026-04-25 00:19:42 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:42 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/5097
Author: @sypherin
Created: 3/3/2026
Status: ❌ Closed

Base: master ← Head: fix/author-duplication

📝 Commits (1)

  • 9cf02e4 Fix author duplication - add optional chaining

📊 Changes

3 files changed (+3 additions, -3 deletions)

View changed files

📝 client/cypress/tests/components/cards/AuthorCard.cy.js (+1 -1)
📝 server/SocketAuthority.js (+1 -1)
📝 server/controllers/AuthorController.js (+1 -1)

📄 Description

fix: [Bug]: Author duplicating - Issue with empty space/abriviations (#5037)

Summary

Fixes #5037

Problem

[Bug]: Author duplicating - Issue with empty space/abriviations

What happened?

I have a few books by J.N. Chaney in ABS. Quick match, or match of any kind really, is putting them all under a single entry for the most part. But I have a book now that insists
J. N. Chaney is different from J.N. Chaney

What did you expect to happen?

It should know that the extra spaces can be ignored since the author already exists with a properly matched profile and ASIN.

Steps to reproduce the issue

  1. Have multiple books by same author
  2. Find quickmatch d...

Solution

Applied fix based on the before/after code provided in the issue.

Fix Type

  • Complexity: EASY
  • Category: general
  • Files changed: See patch

Testing

  • Verify the fix resolves the reported issue
  • Run existing test suite
  • No regressions introduced

Generated by pr-contributor — autonomous contribution bot

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/5097 **Author:** [@sypherin](https://github.com/sypherin) **Created:** 3/3/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/author-duplication` --- ### 📝 Commits (1) - [`9cf02e4`](https://github.com/advplyr/audiobookshelf/commit/9cf02e4981fbb64c1e480c608ec29b1c8627a101) Fix author duplication - add optional chaining ### 📊 Changes **3 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `client/cypress/tests/components/cards/AuthorCard.cy.js` (+1 -1) 📝 `server/SocketAuthority.js` (+1 -1) 📝 `server/controllers/AuthorController.js` (+1 -1) </details> ### 📄 Description # fix: [Bug]: Author duplicating - Issue with empty space/abriviations (#5037) ## Summary Fixes #5037 ### Problem [Bug]: Author duplicating - Issue with empty space/abriviations ### What happened? I have a few books by J.N. Chaney in ABS. Quick match, or match of any kind really, is putting them all under a single entry for the most part. But I have a book now that insists J. N. Chaney is different from J.N. Chaney ### What did you expect to happen? It should know that the extra spaces can be ignored since the author already exists with a properly matched profile and ASIN. ### Steps to reproduce the issue 1. Have multiple books by same author 2. Find quickmatch d... ### Solution Applied fix based on the before/after code provided in the issue. ### Fix Type - Complexity: **EASY** - Category: `general` - Files changed: See patch ### Testing - [ ] Verify the fix resolves the reported issue - [ ] Run existing test suite - [ ] No regressions introduced --- *Generated by [pr-contributor](https://github.com/sypherin/openclaw-config) — autonomous contribution bot* --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:42 +02:00
adam closed this issue 2026-04-25 00:19:42 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4423
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?