starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #5089] feat: add autocomplete attributes for password manager support #4421

New Issue
Open
opened 2026-04-25 00:19:41 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:41 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/5089
Author: @meek2100
Created: 2/26/2026
Status: 🔄 Open

Base: master ← Head: pass_managers

📝 Commits (1)

  • a9e1265 Add autocomplete attributes to login and setup fields for password manager support

📊 Changes

3 files changed (+11 additions, -9 deletions)

View changed files

📝 client/components/ui/TextInput.vue (+3 -2)
📝 client/components/ui/TextInputWithLabel.vue (+3 -2)
📝 client/pages/login.vue (+5 -5)

📄 Description

PR Description

Brief summary

Adds standard HTML autocomplete attributes to the login and initial server setup forms to improve support for browser-native and third-party password managers (e.g., Apple Keychain, 1Password, Bitwarden).

Which issue is fixed?

Addresses the need for improved credential autofill support.

In-depth Description

This PR updates the ui-text-input and ui-text-input-with-label components to accept an autocomplete prop, which is then bound to the underlying HTML <input> element.

The login.vue page has been updated to use these new props:

  • Initial Server Setup: Sets autocomplete="username" and autocomplete="new-password" to help password managers suggest and save root credentials during setup.
  • Login: Sets autocomplete="username" and autocomplete="current-password" to ensure saved credentials are correctly mapped and autofilled by the OS/browser.

This is a non-breaking change that follows standard Web accessibility and security practices for credential handling.

How have you tested this?

  1. Manual Web Test: Verified in a browser (Chrome/Firefox) that the "Save Password" prompt appears correctly after a successful login.
  2. Autofill Verification: Confirmed that saved credentials appear as suggestions in the username field.
  3. Setup Test: Verified that the password manager suggests a "Strong Password" for the new-password fields during the server initialization screen.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/5089 **Author:** [@meek2100](https://github.com/meek2100) **Created:** 2/26/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `pass_managers` --- ### 📝 Commits (1) - [`a9e1265`](https://github.com/advplyr/audiobookshelf/commit/a9e12657f572d4ac1ef9b27d09ae1137f6f9f7c0) Add autocomplete attributes to login and setup fields for password manager support ### 📊 Changes **3 files changed** (+11 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `client/components/ui/TextInput.vue` (+3 -2) 📝 `client/components/ui/TextInputWithLabel.vue` (+3 -2) 📝 `client/pages/login.vue` (+5 -5) </details> ### 📄 Description ## PR Description ### Brief summary Adds standard HTML `autocomplete` attributes to the login and initial server setup forms to improve support for browser-native and third-party password managers (e.g., Apple Keychain, 1Password, Bitwarden). ### Which issue is fixed? Addresses the need for improved credential autofill support. ### In-depth Description This PR updates the `ui-text-input` and `ui-text-input-with-label` components to accept an `autocomplete` prop, which is then bound to the underlying HTML `<input>` element. The `login.vue` page has been updated to use these new props: * **Initial Server Setup**: Sets `autocomplete="username"` and `autocomplete="new-password"` to help password managers suggest and save root credentials during setup. * **Login**: Sets `autocomplete="username"` and `autocomplete="current-password"` to ensure saved credentials are correctly mapped and autofilled by the OS/browser. This is a non-breaking change that follows standard Web accessibility and security practices for credential handling. ### How have you tested this? 1. **Manual Web Test**: Verified in a browser (Chrome/Firefox) that the "Save Password" prompt appears correctly after a successful login. 2. **Autofill Verification**: Confirmed that saved credentials appear as suggestions in the username field. 3. **Setup Test**: Verified that the password manager suggests a "Strong Password" for the `new-password` fields during the server initialization screen. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:41 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4421
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?