starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #5066] [CLOSED] Dev/non root user #4411

New Issue
Closed
opened 2026-04-25 00:19:38 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:38 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/5066
Author: @Vylyne
Created: 2/17/2026
Status: ❌ Closed

Base: master ← Head: dev/non-root-user

📝 Commits (10+)

  • 8e0ccf5 added PUID and GUID Args For buildtime UID and GID specification, Add User and Group with those ids and set User at entrypiont call. there will be permission errors.
  • 7403a01 updated build yaml to allow builds in other repos, and build on dev branches
  • d4e807a changed default uid and group id to 5000
  • aa3a0d7 remove --purge from apt del
  • 3d5eaa6 changed to reuse node user, renaming and re-iding.
  • 71b4f70 added move home to user mod
  • 0eb1905 fixed homepath
  • 6c79d28 making sure /config and /metadata and are world writable for --user support incase they're not bind mounted.
  • ce1540e reverted default IDs to 1000 which is what the node user is created as. Though this default for the container was root. Figured 1000 is a safer default then root and will fit most basic user setups.
  • d9e7db2 Added Global Definition of PUID and GUID for ease of management only.

📊 Changes

2 files changed (+41 additions, -17 deletions)

View changed files

📝 .github/workflows/docker-build.yml (+22 -12)
📝 Dockerfile (+19 -5)

📄 Description

Brief summary

Which issue is fixed?

In-depth Description

How have you tested this?

Screenshots

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/5066 **Author:** [@Vylyne](https://github.com/Vylyne) **Created:** 2/17/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dev/non-root-user` --- ### 📝 Commits (10+) - [`8e0ccf5`](https://github.com/advplyr/audiobookshelf/commit/8e0ccf59e0de018a4eae8c1b8d79274bcb1be1d3) added PUID and GUID Args For buildtime UID and GID specification, Add User and Group with those ids and set User at entrypiont call. there will be permission errors. - [`7403a01`](https://github.com/advplyr/audiobookshelf/commit/7403a0199eb7e93d4c0e224c5ae3b23ef2dd0aab) updated build yaml to allow builds in other repos, and build on dev branches - [`d4e807a`](https://github.com/advplyr/audiobookshelf/commit/d4e807a86c29a5f6a8040befade4dc8666b9a27c) changed default uid and group id to 5000 - [`aa3a0d7`](https://github.com/advplyr/audiobookshelf/commit/aa3a0d7bff8fab241d88fd0b160aea045101785e) remove --purge from apt del - [`3d5eaa6`](https://github.com/advplyr/audiobookshelf/commit/3d5eaa6577dceba313001397460d6a48e3b92890) changed to reuse node user, renaming and re-iding. - [`71b4f70`](https://github.com/advplyr/audiobookshelf/commit/71b4f70034e8d9787a3fa6b398e1461b707cf244) added move home to user mod - [`0eb1905`](https://github.com/advplyr/audiobookshelf/commit/0eb1905d1f538d3d5d6ace7d9c8db48c74d8e636) fixed homepath - [`6c79d28`](https://github.com/advplyr/audiobookshelf/commit/6c79d28329274aa6e32ed458454810d4f903a843) making sure /config and /metadata and are world writable for --user support incase they're not bind mounted. - [`ce1540e`](https://github.com/advplyr/audiobookshelf/commit/ce1540e78116453574c77cf23309dd93315e7850) reverted default IDs to 1000 which is what the node user is created as. Though this default for the container was root. Figured 1000 is a safer default then root and will fit most basic user setups. - [`d9e7db2`](https://github.com/advplyr/audiobookshelf/commit/d9e7db2b5c691f49e5e3d8e37b67930c6e9e6ee4) Added Global Definition of PUID and GUID for ease of management only. ### 📊 Changes **2 files changed** (+41 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/docker-build.yml` (+22 -12) 📝 `Dockerfile` (+19 -5) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary <!-- Please provide a brief summary of what your PR attempts to achieve. --> ## Which issue is fixed? <!-- Which issue number does this PR fix? Ex: "Fixes #1234" --> ## In-depth Description <!-- Describe your solution in more depth. How does it work? Why is this the best solution? Does it solve a problem that affects multiple users or is this an edge case for your setup? --> ## How have you tested this? <!-- Please describe in detail with reproducible steps how you tested your changes. --> ## Screenshots <!-- If your PR includes any changes to the web client, please include screenshots or a short video from before and after your changes. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:38 +02:00
adam closed this issue 2026-04-25 00:19:39 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4411
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?