starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #5045] fix: support uploading files to existing library item folders #4403

New Issue
Open
opened 2026-04-25 00:19:37 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:37 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/5045
Author: @ScottamDendar
Created: 2/9/2026
Status: 🔄 Open

Base: master ← Head: master

📝 Commits (1)

  • 3976137 feat: Support Uploading files to existing library item folders

📊 Changes

2 files changed (+27 additions, -20 deletions)

View changed files

📝 client/pages/upload/index.vue (+25 -18)
📝 server/controllers/FileSystemController.js (+2 -2)

📄 Description

Brief summary

This PR attempts to address enhancement #1894, Attempting to upload a file/book to existing library items. I simply changed the pathexists api call to accept the filepath of a file within an item. The UI was also updated to call the pathexists endpoint per file within an item, as a result.

Which issue is fixed?

Closes #1894

In-depth Description

Someone tried to compliment my audiobook with an ebook supplimant, and ran into this issue. I thought it would be a good into the project.

The update is rather straightforward, but I decided to allow partial uploads. this means if at least 1 file doesnt exist (meaning the rest are dupes), the upload will proceed with the new file. I could change it though that all the files must not exist before uploading.

I understand there is a UI update in the works, but considering its months away, and this update is very tiny, I was hoping it would be acceptable.

How have you tested this?

I ran the npm run test command, but found the controller I updated had no unit tests. If desired, i could start some, though itd certainly take me a little longer.

  1. create library
  2. upload file 'foo.m4b' with author 'anyguy'
  3. attempt to upload file 'foo.m4b' with author 'anyguy' again
  • it should fail, as it used to
  1. upload file 'foo.pdf' with author 'anyguy'
  2. Notice Library has book 'Foo' from 'anyguy' with both uploads being successful.

Screenshots

Attached a video of the change working, and also blocking a re-upload (im used to work where the video would embed, I could post it privately to youtube if we still want it embedded lol).
https://github.com/user-attachments/assets/54e35a66-681e-484c-87df-84bf40de9fa8

Without my changes, the red error happens each time.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/5045 **Author:** [@ScottamDendar](https://github.com/ScottamDendar) **Created:** 2/9/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`3976137`](https://github.com/advplyr/audiobookshelf/commit/397613795fd9a5c1db7542e9af8041c0b82c228f) feat: Support Uploading files to existing library item folders ### 📊 Changes **2 files changed** (+27 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `client/pages/upload/index.vue` (+25 -18) 📝 `server/controllers/FileSystemController.js` (+2 -2) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary This PR attempts to address enhancement #1894, Attempting to upload a file/book to existing library items. I simply changed the `pathexists` api call to accept the filepath of a file within an item. The UI was also updated to call the `pathexists` endpoint per file within an item, as a result. <!-- Please provide a brief summary of what your PR attempts to achieve. --> ## Which issue is fixed? Closes #1894 <!-- Which issue number does this PR fix? Ex: "Fixes #1234" --> ## In-depth Description Someone tried to compliment my audiobook with an ebook supplimant, and ran into this issue. I thought it would be a good into the project. The update is rather straightforward, but I decided to allow partial uploads. this means if at least 1 file _doesnt_ exist (meaning the rest are dupes), the upload will proceed with the new file. I could change it though that all the files must not exist before uploading. I understand there is a UI update in the works, but considering its months away, and this update is very tiny, I was hoping it would be acceptable. <!-- Describe your solution in more depth. How does it work? Why is this the best solution? Does it solve a problem that affects multiple users or is this an edge case for your setup? --> ## How have you tested this? I ran the `npm run test` command, but found the controller I updated had no unit tests. If desired, i could start some, though itd certainly take me a little longer. 1. create library 2. upload file 'foo.m4b' with author 'anyguy' 3. attempt to upload file 'foo.m4b' with author 'anyguy' again - it should fail, as it used to 4. upload file 'foo.pdf' with author 'anyguy' 5. Notice Library has book 'Foo' from 'anyguy' with both uploads being successful. <!-- Please describe in detail with reproducible steps how you tested your changes. --> ## Screenshots Attached a video of the change working, and also blocking a re-upload (im used to work where the video would embed, I could post it privately to youtube if we still want it embedded lol). https://github.com/user-attachments/assets/54e35a66-681e-484c-87df-84bf40de9fa8 Without my changes, the red error happens each time. <!-- If your PR includes any changes to the web client, please include screenshots or a short video from before and after your changes. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:37 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4403
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?