starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4970] Make the download icon easier to see on share page for books with light covers #4386

New Issue
Open
opened 2026-04-25 00:19:33 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:33 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4970
Author: @sir-wilhelm
Created: 1/8/2026
Status: 🔄 Open

Base: master ← Head: share-download-color-correct

📝 Commits (1)

  • ebf8b39 Make the download icon easier to see with light covers.

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 client/pages/share/_slug.vue (+4 -1)

📄 Description

Brief summary

This change improves the accessibility of the download icon on the share page.

Which issue is fixed?

n/a

In-depth Description

The current page always displays a light icon, but it's can be quite invisible for books with light covers. This just takes advantage of a property that's already being set (this.coverBgIsLight) to use a dark icon if the cover/background is light.

How have you tested this?

Tested on dev instance with light cover, dark cover, and no cover.

Screenshots

pre change:
image
image

post change:
light cover:
image
image

dark cover:
image
image

no cover (uses the dark cover color):
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4970 **Author:** [@sir-wilhelm](https://github.com/sir-wilhelm) **Created:** 1/8/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `share-download-color-correct` --- ### 📝 Commits (1) - [`ebf8b39`](https://github.com/advplyr/audiobookshelf/commit/ebf8b39c00a83d30219e6524a864230318b94e80) Make the download icon easier to see with light covers. ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `client/pages/share/_slug.vue` (+4 -1) </details> ### 📄 Description ## Brief summary This change improves the accessibility of the download icon on the share page. ## Which issue is fixed? n/a ## In-depth Description The current page always displays a light icon, but it's can be quite invisible for books with light covers. This just takes advantage of a property that's already being set (`this.coverBgIsLight`) to use a dark icon if the cover/background is light. ## How have you tested this? Tested on dev instance with light cover, dark cover, and no cover. ## Screenshots pre change: <img width="155" height="148" alt="image" src="https://github.com/user-attachments/assets/547dba4d-60bc-4d07-bb07-1f0e0819fa0e" /> <img width="114" height="128" alt="image" src="https://github.com/user-attachments/assets/2b5cf34f-81cc-4855-bd06-883874dc1735" /> post change: light cover: <img width="69" height="73" alt="image" src="https://github.com/user-attachments/assets/5dfa0a95-f5b2-4d55-b786-504f1541609e" /> <img width="73" height="76" alt="image" src="https://github.com/user-attachments/assets/aba35d59-d5f6-4014-a48a-b21bfb7396da" /> dark cover: <img width="59" height="57" alt="image" src="https://github.com/user-attachments/assets/c5d97b76-3b77-4591-9628-28a2116a316a" /> <img width="70" height="78" alt="image" src="https://github.com/user-attachments/assets/826136d5-ccf9-488b-bf1a-9dbffa1844d9" /> no cover (uses the dark cover color): <img width="50" height="60" alt="image" src="https://github.com/user-attachments/assets/1be71a98-ee9b-483b-bcd6-9113b23983ac" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:33 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4386
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?