starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4952] [MERGED] Display localized/styled text for selected filter. #4379

New Issue
Closed
opened 2026-04-25 00:19:31 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:31 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4952
Author: @sir-wilhelm
Created: 1/1/2026
Status: ✅ Merged
Merged: 2/1/2026
Merged by: @advplyr

Base: master ← Head: use-localized-text-for-selected-filter

📝 Commits (1)

  • e6d99d0 Display localized/styled text for selected filter.

📊 Changes

1 file changed (+12 additions, -0 deletions)

View changed files

📝 client/components/controls/LibraryFilterSelect.vue (+12 -0)

📄 Description

Brief summary

Currently the selected filter drop down displays the id used to do the filtering by the server. This change aims to use the friendly / localized value instead of the id.

Which issue is fixed?

None, discussed in discord.

In-depth Description

The drop down is populated by selectedText(), and it handles quite a few edge cases. I just added 4 more filter types to the list. If a filter is selected it'll look up the friendly name from the drop down's value list and select it based on the selected id.

How have you tested this?

Ran it on my dev instance.

Screenshots

Original uses ids in the drop down:
17673071721087171548396986289613

After the change it'll use the friendly name:
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4952 **Author:** [@sir-wilhelm](https://github.com/sir-wilhelm) **Created:** 1/1/2026 **Status:** ✅ Merged **Merged:** 2/1/2026 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `use-localized-text-for-selected-filter` --- ### 📝 Commits (1) - [`e6d99d0`](https://github.com/advplyr/audiobookshelf/commit/e6d99d07f0e5c649d873d7ba6df40be2e0b9a727) Display localized/styled text for selected filter. ### 📊 Changes **1 file changed** (+12 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `client/components/controls/LibraryFilterSelect.vue` (+12 -0) </details> ### 📄 Description ## Brief summary Currently the selected filter drop down displays the id used to do the filtering by the server. This change aims to use the friendly / localized value instead of the id. ## Which issue is fixed? None, discussed in discord. ## In-depth Description The drop down is populated by `selectedText()`, and it handles quite a few edge cases. I just added 4 more filter types to the list. If a filter is selected it'll look up the friendly name from the drop down's value list and select it based on the selected id. ## How have you tested this? Ran it on my dev instance. ## Screenshots Original uses ids in the drop down: <img width="256" height="237" alt="17673071721087171548396986289613" src="https://github.com/user-attachments/assets/d95c32ae-3243-4582-8250-28c79a265291" /> After the change it'll use the friendly name: <img width="210" height="225" alt="image" src="https://github.com/user-attachments/assets/58f2dd3b-fc85-4e5d-b376-5a1d58123b85" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:31 +02:00
adam closed this issue 2026-04-25 00:19:31 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4379
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?