mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#4355
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/advplyr/audiobookshelf/pull/4828
Author: @S-Reinhard
Created: 11/13/2025
Status: 🔄 Open
Base:
master← Head:#4584-sort-options-for-narrators📝 Commits (6)
4f33de1added sorting narators by name and book count0a963b4Merge branch 'advplyr:master' into #4584-sort-options-for-narrators60624ecMerge branch 'advplyr:master' into #4584-sort-options-for-narrators2793b54Merge branch 'advplyr:master' into #4584-sort-options-for-narrators5148502implemented server side sortf688beaMerge branch 'advplyr:master' into #4584-sort-options-for-narrators📊 Changes
2 files changed (+37 additions, -5 deletions)
View changed files
📝
client/pages/library/_library/narrators.vue(+30 -4)📝
server/controllers/LibraryController.js(+7 -1)📄 Description
Brief summary
Allow users to sort narrators by name and book count.
Which issue is fixed?
Fixes https://github.com/advplyr/audiobookshelf/issues/4584
In-Depth Description
How the narrator sorting works:
Users can sort narrators by clicking on the corresponding table header cells.
When hovering over these cells, the cursor changes to a pointer. Because there are no lines separating the tabel cells, the text in the corresponding cell is underlined.
Clicking the same header again toggles the sorting direction (ascending/descending).
An arrow icon visually indicates the current sorting direction and only appears in the active column to show which column is being sorted.
To ensure the visual indicators and sorting logic remain in sync, both are driven by shared state properties like the currently selected attribute and sort order.
Those parameters are used as query params when fetching the narrators.
On the server side the query params from the request are replaced with known strings to ensure working default and fallback sorting options, before sorting the list of narrators using naturalSort().
Why this solution is effective:
It follows the design principle of external consistency—the behavior and appearance mimic commonly used sortable tables, making the feature intuitive and familiar for users.
Server side sorting will work in the future even when paging is added.
Areas for Improvement:
The current implementation uses a Unicode arrow character returned from a function. This wasn't my first choice; I would have preferred using an icon to support
aria-labels. However, I was unable to insert a standalone icon without also introducing a button. If icon-based implementation is preferred, I would appreciate guidance on the icon library and documentation used in this project, along with relevant code examples.Fetching a new list of narrators every time the order changes is a bit slow and creates unnecessary traffic, this could be improved by caching.
Who is affected:
While the change is small, it affects many users because it adds function to the web client.
How Have You Tested This?
I ran the project inside a dev container.
Then I added sample audiobooks as test data and navigated to the narrator page in a web browser. I verified the behavior when hovering over, clicking, and repeatedly interacting with the header cells of sortable columns.
Additionally, I confirmed that the edit and delete buttons next to each narrator still function as expected.
Screenshots
Before:
After:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.