starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4808] [MERGED] Support eac3 and ac3 in transcodes #4353

New Issue
Closed
opened 2026-04-25 00:19:24 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:24 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4808
Author: @Vito0912
Created: 11/7/2025
Status: ✅ Merged
Merged: 11/9/2025
Merged by: @advplyr

Base: master ← Head: feat/eac3

📝 Commits (3)

📊 Changes

1 file changed (+11 additions, -2 deletions)

View changed files

📝 server/objects/Stream.js (+11 -2)

📄 Description

Brief summary

Basically, HLS allows AC-3. The problem is that if the browser does not support AC-3, it fails again. Since the MIME type is MP4, we have to force the codec by codec.
This has the downside that browsers that fail and transcode an AC-3 file will only get an AAC file. But I think this should never happen because it would then perform a direct play. So this should fix EAC-3/AC-3 not playable

Which issue is fixed?

#4798

In-depth Description

See the conversation in the attached issue and my short description

How have you tested this?

Tried to play an EAC-3 file with Firefox which does not support it. Before it failed. Now it worked. It should not affect any other codecs. So nothing that was not broken should be able to be broken now.

Thanks to @TheStaticTurtle

Screenshots

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4808 **Author:** [@Vito0912](https://github.com/Vito0912) **Created:** 11/7/2025 **Status:** ✅ Merged **Merged:** 11/9/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `feat/eac3` --- ### 📝 Commits (3) - [`2cf6e8a`](https://github.com/advplyr/audiobookshelf/commit/2cf6e8a5fe9040b89e280146505c1241885f4788) Support eac3 - [`3316505`](https://github.com/advplyr/audiobookshelf/commit/3316505d1c9b8f9af2606ef628aeb765d309cf11) Really makes sure nothing can break - [`763d881`](https://github.com/advplyr/audiobookshelf/commit/763d8810e3fcff9b8e16ff4a6769654a9e0541d3) Update Stream ac3/eac3 check ### 📊 Changes **1 file changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server/objects/Stream.js` (+11 -2) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary Basically, HLS allows AC-3. The problem is that if the browser does not support AC-3, it fails again. Since the MIME type is MP4, we have to force the codec by codec. This has the downside that browsers that fail and transcode an AC-3 file will only get an AAC file. But I think this should never happen because it would then perform a direct play. So this should fix EAC-3/AC-3 not playable ## Which issue is fixed? #4798 ## In-depth Description See the conversation in the attached issue and my short description ## How have you tested this? Tried to play an EAC-3 file with Firefox which does not support it. Before it failed. Now it worked. It should not affect any other codecs. So nothing that was not broken should be able to be broken now. Thanks to @TheStaticTurtle ## Screenshots <!-- If your PR includes any changes to the web client, please include screenshots or a short video from before and after your changes. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:24 +02:00
adam closed this issue 2026-04-25 00:19:24 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4353
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?