starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4788] Increasing the timeout for BookFinder - some metadata providers need more time #4347

New Issue
Open
opened 2026-04-25 00:19:22 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:22 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4788
Author: @TN-SKYC
Created: 10/31/2025
Status: 🔄 Open

Base: master ← Head: provider-timeout

📝 Commits (1)

  • 847045b Increasing the timeout for bookfinder - some metadata providers heavily throttle the requests, original 10s is not enough.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 server/finders/BookFinder.js (+1 -1)

📄 Description

Brief summary

Some custom metadata providers are slow due to the providers throttling the responses. In v2.30 the timeout went down to 10s (from 30s). Even the 30s sometimes was not enough.

Which issue is fixed?

Timeout increased for waiting for data from metadata providers.

In-depth Description

Changing the timeout from 10s to 120s to let custom metadata providers function properly - we have no control over providers decisions to throttle the responses.

How have you tested this?

Yes, it's a simple timeout increase. When timeout hits, logs show:

2025-10-28 20:52:36.963 ERROR [CustomMetadataProvider] Search error [AxiosError: timeout of 30000ms exceeded] { code: 'ECONNABORTED', config: { transitional: { silentJSONParsing: true, forcedJSONParsing: true, clarifyTimeoutError: false }, adapter: [Function: httpAdapter], transformRequest: [ [Function: transformRequest] ], transformResponse: [ [Function: transformResponse] ], timeout: 30000, xsrfCookieName: 'XSRF-TOKEN',

Screenshots

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4788 **Author:** [@TN-SKYC](https://github.com/TN-SKYC) **Created:** 10/31/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `provider-timeout` --- ### 📝 Commits (1) - [`847045b`](https://github.com/advplyr/audiobookshelf/commit/847045b32af23d326b9c3bd9ffa994d841921a64) Increasing the timeout for bookfinder - some metadata providers heavily throttle the requests, original 10s is not enough. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/finders/BookFinder.js` (+1 -1) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary Some custom metadata providers are slow due to the providers throttling the responses. In v2.30 the timeout went down to 10s (from 30s). Even the 30s sometimes was not enough. <!-- Please provide a brief summary of what your PR attempts to achieve. --> ## Which issue is fixed? Timeout increased for waiting for data from metadata providers. <!-- Which issue number does this PR fix? Ex: "Fixes #1234" --> ## In-depth Description Changing the timeout from 10s to 120s to let custom metadata providers function properly - we have no control over providers decisions to throttle the responses. <!-- Describe your solution in more depth. How does it work? Why is this the best solution? Does it solve a problem that affects multiple users or is this an edge case for your setup? --> ## How have you tested this? Yes, it's a simple timeout increase. When timeout hits, logs show: ``` 2025-10-28 20:52:36.963 ERROR [CustomMetadataProvider] Search error [AxiosError: timeout of 30000ms exceeded] { code: 'ECONNABORTED', config: { transitional: { silentJSONParsing: true, forcedJSONParsing: true, clarifyTimeoutError: false }, adapter: [Function: httpAdapter], transformRequest: [ [Function: transformRequest] ], transformResponse: [ [Function: transformResponse] ], timeout: 30000, xsrfCookieName: 'XSRF-TOKEN', ``` <!-- Please describe in detail with reproducible steps how you tested your changes. --> ## Screenshots <!-- If your PR includes any changes to the web client, please include screenshots or a short video from before and after your changes. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:22 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4347
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?