starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4745] [Enhancement] Clairfy when user has insufficent permissions to delete items from issues tab #4337

New Issue
Open
opened 2026-04-25 00:19:20 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:20 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4745
Author: @LiamWilkinson
Created: 10/12/2025
Status: 🔄 Open

Base: master ← Head: add_tool_tip_for_insufficient_delete_permission

📝 Commits (1)

  • 41a498e Add tool tip to disabled delete button when user does not have permissions to delete items on issues tab

📊 Changes

2 files changed (+4 additions, -0 deletions)

View changed files

📝 client/components/app/BookShelfToolbar.vue (+3 -0)
📝 client/strings/en-us.json (+1 -0)

📄 Description

Brief summary

Add tool tip to disabled delete button when user does not have permissions to delete items on issues tab.

Which issue is fixed?

https://github.com/advplyr/audiobookshelf/issues/3765

In-depth Description

It's unclear that the permissions to delete an item that has issues require permissions a user may not have. When you visit the issues tab logged in as a user that does not have permissions there is no indication that the user has no permission to delete it just doesn't show the button. It would be helpful to know in that case that the user needs to either log into an account with permissions to delete or contact someone that can delete that item from the library.

Example attached:

Screenshot (115)

How have you tested this?

Logged in via a user that does not have permission to delete and see the disabled button, hovering over the disabled button the tool tip displays a message explaining that the user does not have permission to delete:

Screenshot (113)

Regression tested with a user that has permissions to delete:

Screenshot (114)

Screenshots

Attached under testing instructions and PR description.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4745 **Author:** [@LiamWilkinson](https://github.com/LiamWilkinson) **Created:** 10/12/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `add_tool_tip_for_insufficient_delete_permission` --- ### 📝 Commits (1) - [`41a498e`](https://github.com/advplyr/audiobookshelf/commit/41a498e8d2499ab52cbcfdc868d006d1e9dce084) Add tool tip to disabled delete button when user does not have permissions to delete items on issues tab ### 📊 Changes **2 files changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `client/components/app/BookShelfToolbar.vue` (+3 -0) 📝 `client/strings/en-us.json` (+1 -0) </details> ### 📄 Description ## Brief summary Add tool tip to disabled delete button when user does not have permissions to delete items on issues tab. ## Which issue is fixed? https://github.com/advplyr/audiobookshelf/issues/3765 ## In-depth Description It's unclear that the permissions to delete an item that has issues require permissions a user may not have. When you visit the issues tab logged in as a user that does not have permissions there is no indication that the user has no permission to delete it just doesn't show the button. It would be helpful to know in that case that the user needs to either log into an account with permissions to delete or contact someone that can delete that item from the library. Example attached: <img width="951" height="650" alt="Screenshot (115)" src="https://github.com/user-attachments/assets/46c8ae8b-67c6-4596-9df0-2f47ae325c95" /> ## How have you tested this? Logged in via a user that does not have permission to delete and see the disabled button, hovering over the disabled button the tool tip displays a message explaining that the user does not have permission to delete: <img width="959" height="656" alt="Screenshot (113)" src="https://github.com/user-attachments/assets/3473d4f0-d8aa-4f56-b797-a7524d0b8500" /> Regression tested with a user that has permissions to delete: <img width="956" height="713" alt="Screenshot (114)" src="https://github.com/user-attachments/assets/16cdd018-a946-4b00-98a7-a08a950ac8f5" /> ## Screenshots Attached under testing instructions and PR description. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:20 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4337
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?