starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4729] [MERGED] Add a script to build an uncompressed windows executable #4329

New Issue
Closed
opened 2026-04-25 00:19:18 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:18 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4729
Author: @mikiher
Created: 10/8/2025
Status: ✅ Merged
Merged: 10/8/2025
Merged by: @advplyr

Base: master ← Head: build-win-no-compress

📝 Commits (1)

  • 00c62fa Add a script to build an uncompressed windows executable

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 package.json (+1 -0)

📄 Description

Brief summary

This is a simple change to add a package.json script that build an uncompressed windows executable.

Which issue is fixed?

If I'm right about this, this should fix #2998.

In-depth Description

I've done some additional analysis of the code in pkg bootstrap.js in which all of the crashes are reported.
It looks like this code path (which decompresses files into an external temp directory) is only reached when the -C option is used in the pkg command line.

I went through the code with chatgpt, and it seems like there's a potential stale caching bug in the code path that crashes, but until I nail it down fully, modify the code, and pass through yao-pkg code review, it looks like just removing the -C option will mitigiate the issue.

Another indicator that this might be the issue is that linuxpackager does not use the -C option, and we've never seen reports on this issue from linux users.

The uncompressed version doesn't weight a lot more than the compressed one - about 40% larger - and hopefully this is a temporary change and we'll be able to move back to compressed executables when the pkg bug is fixed.

How have you tested this?

This doesn't change anything in the server code itself.
I intend to replcace the compressed version with the uncompressed one in the Windows installer, check it and let the latest reporter check it, and see if it resolves the issue for them.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4729 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 10/8/2025 **Status:** ✅ Merged **Merged:** 10/8/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `build-win-no-compress` --- ### 📝 Commits (1) - [`00c62fa`](https://github.com/advplyr/audiobookshelf/commit/00c62fa49451f0fc2c3bb65fdeb2eee361bcd9e4) Add a script to build an uncompressed windows executable ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+1 -0) </details> ### 📄 Description ## Brief summary This is a simple change to add a package.json script that build an uncompressed windows executable. ## Which issue is fixed? If I'm right about this, this should fix #2998. ## In-depth Description I've done some additional analysis of the code in pkg bootstrap.js in which all of the crashes are reported. It looks like this code path (which decompresses files into an external temp directory) is only reached when the `-C` option is used in the `pkg` command line. I went through the code with chatgpt, and it seems like there's a potential stale caching bug in the code path that crashes, but until I nail it down fully, modify the code, and pass through yao-pkg code review, it looks like just removing the `-C` option will mitigiate the issue. Another indicator that this might be the issue is that `linuxpackager` does not use the `-C` option, and we've never seen reports on this issue from linux users. The uncompressed version doesn't weight a lot more than the compressed one - about 40% larger - and hopefully this is a temporary change and we'll be able to move back to compressed executables when the pkg bug is fixed. ## How have you tested this? This doesn't change anything in the server code itself. I intend to replcace the compressed version with the uncompressed one in the Windows installer, check it and let the latest reporter check it, and see if it resolves the issue for them. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:18 +02:00
adam closed this issue 2026-04-25 00:19:18 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4329
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?