starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4664] [MERGED] Fix issue with episode downloads without streams #4313

New Issue
Closed
opened 2026-04-25 00:19:15 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:15 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4664
Author: @advplyr
Created: 9/11/2025
Status: ✅ Merged
Merged: 9/11/2025
Merged by: @advplyr

Base: master ← Head: episode_download_fallback

📝 Commits (1)

  • a456865 Fix issue with episode downloads without streams, fallback to regular dl on ffprobe fail

📊 Changes

2 files changed (+28 additions, -21 deletions)

View changed files

📝 server/managers/PodcastManager.js (+23 -16)
📝 server/utils/ffmpegHelpers.js (+5 -5)

📄 Description

Brief summary

Update podcast episode downloads to fallback to regular download if the ffprobe fails.

Which issue is fixed?

None, mentioned on Discord

In-depth Description

A private patreon podcast RSS feed that has m4a audio files is unable to be streamed into ffmpeg for download. The audio file gets downloaded with no media streams so the ffprobe fails.

This update moves the non-ffmpeg fallback download to after the ffprobe.

How have you tested this?

This resolves that patreon RSS feed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4664 **Author:** [@advplyr](https://github.com/advplyr) **Created:** 9/11/2025 **Status:** ✅ Merged **Merged:** 9/11/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `episode_download_fallback` --- ### 📝 Commits (1) - [`a456865`](https://github.com/advplyr/audiobookshelf/commit/a456865ec0a61d074e4032b42eb6fd8dfd541a37) Fix issue with episode downloads without streams, fallback to regular dl on ffprobe fail ### 📊 Changes **2 files changed** (+28 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `server/managers/PodcastManager.js` (+23 -16) 📝 `server/utils/ffmpegHelpers.js` (+5 -5) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary Update podcast episode downloads to fallback to regular download if the ffprobe fails. ## Which issue is fixed? None, mentioned on Discord ## In-depth Description A private patreon podcast RSS feed that has m4a audio files is unable to be streamed into ffmpeg for download. The audio file gets downloaded with no media streams so the ffprobe fails. This update moves the non-ffmpeg fallback download to after the ffprobe. ## How have you tested this? This resolves that patreon RSS feed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:15 +02:00
adam closed this issue 2026-04-25 00:19:15 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4313
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?