starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4635] [MERGED] Fix Invalid callback URL - must be same-origin for NPM users #4307

New Issue
Closed
opened 2026-04-25 00:19:13 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:13 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4635
Author: @Vito0912
Created: 8/30/2025
Status: ✅ Merged
Merged: 9/3/2025
Merged by: @advplyr

Base: master ← Head: feat/OIDCfix

📝 Commits (1)

📊 Changes

1 file changed (+10 additions, -1 deletions)

View changed files

📝 server/auth/OidcAuthStrategy.js (+10 -1)

📄 Description

Brief summary

NPM, even if it's not the spec, returns 'x-forwarded-proto': 'http, https', as header.

Which issue is fixed?

Fixes #4609

In-depth Description

See Discord conversation. This is basically because NPM adds both protocols as forwarded.

How have you tested this?

Local NPM setup

Screenshots

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4635 **Author:** [@Vito0912](https://github.com/Vito0912) **Created:** 8/30/2025 **Status:** ✅ Merged **Merged:** 9/3/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `feat/OIDCfix` --- ### 📝 Commits (1) - [`50e2fe7`](https://github.com/advplyr/audiobookshelf/commit/50e2fe7fd22d03915a2c17ff5248b7ca1e245944) Fix http/https error ### 📊 Changes **1 file changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/auth/OidcAuthStrategy.js` (+10 -1) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary NPM, even if it's not the spec, returns `'x-forwarded-proto': 'http, https',` as header. ## Which issue is fixed? Fixes #4609 ## In-depth Description See Discord conversation. This is basically because NPM adds both protocols as forwarded. ## How have you tested this? Local NPM setup ## Screenshots <!-- If your PR includes any changes to the web client, please include screenshots or a short video from before and after your changes. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:13 +02:00
adam closed this issue 2026-04-25 00:19:13 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4307
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?