starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4633] [CLOSED] Update OpenID auth URI construction in login page #4306

New Issue
Closed
opened 2026-04-25 00:19:13 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:13 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4633
Author: @Vito0912
Created: 8/30/2025
Status: ❌ Closed

Base: master ← Head: feat/fixOCIDRedirect

📝 Commits (2)

  • 16873d3 Update OpenID auth URI construction in login page
  • 9c06b0f Simplified AuthUri

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 client/pages/login.vue (+1 -1)

📄 Description

Brief summary

Outlined in https://github.com/advplyr/audiobookshelf/issues/4609#issuecomment-3239221989 the OIDC button does not respect the currently opened URL, but instead uses the environment. This normally should not be an issue, but with the new enforced callback URLs it should at least match the same host/origin as the callback URL. That is why location is used. This does not fix the outlined issue though. But e.g. for dev builds that always gets redirected to the localhost address even if not using localhost

And for dev environments serverUrl is always set to localhost:3333. If you connect to :3333 the oidc still redirects to localhost. For deployments this is a non issue.

Which issue is fixed?

In-depth Description

How have you tested this?

Tested with autoLaunch and without autoLaunch

Screenshots

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4633 **Author:** [@Vito0912](https://github.com/Vito0912) **Created:** 8/30/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feat/fixOCIDRedirect` --- ### 📝 Commits (2) - [`16873d3`](https://github.com/advplyr/audiobookshelf/commit/16873d3c3e961a93a840141cbdfaa7b88d77d650) Update OpenID auth URI construction in login page - [`9c06b0f`](https://github.com/advplyr/audiobookshelf/commit/9c06b0f257d4fcbce0c94353939a98b3c2ea6dfa) Simplified AuthUri ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `client/pages/login.vue` (+1 -1) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary Outlined in https://github.com/advplyr/audiobookshelf/issues/4609#issuecomment-3239221989 the OIDC button does not respect the currently opened URL, but instead uses the environment. This normally should not be an issue, but with the new enforced callback URLs it should at least match the same host/origin as the callback URL. That is why `location` is used. This does not fix the outlined issue though. But e.g. for dev builds that always gets redirected to the localhost address even if not using localhost And for dev environments serverUrl is always set to localhost:3333. If you connect to <local ip not localhost>:3333 the oidc still redirects to localhost. For deployments this is a non issue. ## Which issue is fixed? <!-- Which issue number does this PR fix? Ex: "Fixes #1234" --> ## In-depth Description <!-- Describe your solution in more depth. How does it work? Why is this the best solution? Does it solve a problem that affects multiple users or is this an edge case for your setup? --> ## How have you tested this? Tested with autoLaunch and without autoLaunch ## Screenshots <!-- If your PR includes any changes to the web client, please include screenshots or a short video from before and after your changes. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:13 +02:00
adam closed this issue 2026-04-25 00:19:13 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4306
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?