starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4598] [MERGED] Update podcast episode downloads to always attempt embedding meta tags #4298

New Issue
Closed
opened 2026-04-25 00:19:11 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:11 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4598
Author: @advplyr
Created: 8/17/2025
Status: ✅ Merged
Merged: 8/17/2025
Merged by: @advplyr

Base: master ← Head: episode_meta_tagging

📝 Commits (1)

  • a968aca Update podcast episode downloads to always attempt embedding meta tags regardless of format

📊 Changes

2 files changed (+11 additions, -32 deletions)

View changed files

📝 server/managers/PodcastManager.js (+11 -22)
📝 server/objects/PodcastEpisodeDownload.js (+0 -10)

📄 Description

Brief summary

This removes the isMp3 check that was used to only embed meta tags in mp3 podcast episodes. Now all episode downloads will attempt to have meta tags embedded and fallback to a regular download.

Which issue is fixed?

None, discussed in Discord

In-depth Description

A tangentially related issue to this is that some podcast RSS feeds provide the wrong file extension. For example, in #3837 the podcast has .mp3 file extension but the files are actually mp4. In this case the ffmpeg meta tag embed will fail and the episode will fallback to being downloaded without meta tagging.

How have you tested this?

Example RSS feed with 3 .m4a files: https://anchor.fm/s/370d6ccc/podcast/rss
Example RSS feed with .ogg files: https://feeds.feedburner.com/TheLinuxLinkTechShowOgg-vorbisFeed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4598 **Author:** [@advplyr](https://github.com/advplyr) **Created:** 8/17/2025 **Status:** ✅ Merged **Merged:** 8/17/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `episode_meta_tagging` --- ### 📝 Commits (1) - [`a968aca`](https://github.com/advplyr/audiobookshelf/commit/a968aca30463c0091755d2af6d1e875453b3e064) Update podcast episode downloads to always attempt embedding meta tags regardless of format ### 📊 Changes **2 files changed** (+11 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `server/managers/PodcastManager.js` (+11 -22) 📝 `server/objects/PodcastEpisodeDownload.js` (+0 -10) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary This removes the `isMp3` check that was used to only embed meta tags in mp3 podcast episodes. Now all episode downloads will attempt to have meta tags embedded and fallback to a regular download. ## Which issue is fixed? None, discussed in Discord ## In-depth Description A tangentially related issue to this is that some podcast RSS feeds provide the wrong file extension. For example, in #3837 the podcast has `.mp3` file extension but the files are actually mp4. In this case the ffmpeg meta tag embed will fail and the episode will fallback to being downloaded without meta tagging. ## How have you tested this? Example RSS feed with 3 `.m4a` files: <https://anchor.fm/s/370d6ccc/podcast/rss> Example RSS feed with `.ogg` files: <https://feeds.feedburner.com/TheLinuxLinkTechShowOgg-vorbisFeed> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:11 +02:00
adam closed this issue 2026-04-25 00:19:11 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4298
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?