starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4596] [MERGED] Fix freeze on some audio sources #4297

New Issue
Closed
opened 2026-04-25 00:19:11 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:11 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4596
Author: @renesat
Created: 8/16/2025
Status: ✅ Merged
Merged: 8/20/2025
Merged by: @advplyr

Base: master ← Head: fix/redirect-url

📝 Commits (1)

  • 8d1f460 Fix freeze on some audio sources

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 server/utils/ffmpegHelpers.js (+1 -0)

📄 Description

Brief summary

Fixed freeze when downloading some episodes.

In-depth Description

On one of the podcasts (https://podster.fm/rss.xml?pid=48291), a situation arose where the download did not complete when downloading an episode. Even timeouts did not work. Through trial and error, I found out that the request would complete with a 200 status code, but would return an empty stream, causing ffmpeg to wait indefinitely for the input stream.

I found out that the podcast did not like the value passed in Accept. By default, Accept: application/json, text/plain, */* is passed. But if you pass Accept: */*, everything starts working and produces the necessary redirects.

How have you tested this?

I checked all my podcasts for functionality on the master version with this change.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4596 **Author:** [@renesat](https://github.com/renesat) **Created:** 8/16/2025 **Status:** ✅ Merged **Merged:** 8/20/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix/redirect-url` --- ### 📝 Commits (1) - [`8d1f460`](https://github.com/advplyr/audiobookshelf/commit/8d1f4606400af8ebb521c39d64e3a4dabc69a00c) Fix freeze on some audio sources ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/ffmpegHelpers.js` (+1 -0) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary Fixed freeze when downloading some episodes. ## In-depth Description On one of the podcasts (https://podster.fm/rss.xml?pid=48291), a situation arose where the download did not complete when downloading an episode. Even timeouts did not work. Through trial and error, I found out that the request would complete with a 200 status code, but would return an empty stream, causing ffmpeg to wait indefinitely for the input stream. I found out that the podcast did not like the value passed in Accept. By default, `Accept: application/json, text/plain, */*` is passed. But if you pass `Accept: */*`, everything starts working and produces the necessary redirects. ## How have you tested this? I checked all my podcasts for functionality on the master version with this change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:11 +02:00
adam closed this issue 2026-04-25 00:19:11 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4297
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?