starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4594] [CLOSED] Testing/Feedback wanted: Add podcast support to metadata embedding tools #4295

New Issue
Closed
opened 2026-04-25 00:19:10 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:10 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4594
Author: @Vito0912
Created: 8/16/2025
Status: ❌ Closed

Base: master ← Head: feat/podcastEmbeding

📝 Commits (2)

  • 69b6c0c Add podcast support to metadata embedding tools
  • 44f13ea fix timestamps

📊 Changes

6 files changed (+212 additions, -62 deletions)

View changed files

📝 client/components/app/Appbar.vue (+1 -1)
📝 client/components/modals/item/EditModal.vue (+0 -1)
📝 client/components/modals/item/tabs/Tools.vue (+15 -3)
📝 server/controllers/ToolsController.js (+2 -2)
📝 server/managers/AudioMetadataManager.js (+126 -32)
📝 server/utils/ffmpegHelpers.js (+68 -23)

📄 Description

Brief summary

This adds support for embeding metadata, changed in ABS (or generally pulled from the RSS feed) to be embeded back to the files.
I tested it on some podcasts and it got results that are working. Sadly it's a bit of a hacky solution, so maybe a complete rewrite is the better solution. But I wanted to make a start so maybe someone want to jump of from it and makes this PR way better

Which issue is fixed?

Fixes #4304 and Discord

In-depth Description

See brief summary, but it basically checks if it's a podcast and then creates the metadata object for every new episode to embed into the files. Since this was not intended, we return the "podcasts" metadata at the API level instead. The files still update correctly.

How have you tested this?

Podcasts from itunes

Screenshots

grafik

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4594 **Author:** [@Vito0912](https://github.com/Vito0912) **Created:** 8/16/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feat/podcastEmbeding` --- ### 📝 Commits (2) - [`69b6c0c`](https://github.com/advplyr/audiobookshelf/commit/69b6c0c79aae1d3115525f8de2fab2c949961a24) Add podcast support to metadata embedding tools - [`44f13ea`](https://github.com/advplyr/audiobookshelf/commit/44f13ea4f60a4daf2034889855ebeaf2e9ddbe61) fix timestamps ### 📊 Changes **6 files changed** (+212 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `client/components/app/Appbar.vue` (+1 -1) 📝 `client/components/modals/item/EditModal.vue` (+0 -1) 📝 `client/components/modals/item/tabs/Tools.vue` (+15 -3) 📝 `server/controllers/ToolsController.js` (+2 -2) 📝 `server/managers/AudioMetadataManager.js` (+126 -32) 📝 `server/utils/ffmpegHelpers.js` (+68 -23) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary This adds support for embeding metadata, changed in ABS (or generally pulled from the RSS feed) to be embeded back to the files. I tested it on some podcasts and it got results that are working. Sadly it's a bit of a hacky solution, so maybe a complete rewrite is the better solution. But I wanted to make a start so maybe someone want to jump of from it and makes this PR way better ## Which issue is fixed? Fixes #4304 and Discord ## In-depth Description See brief summary, but it basically checks if it's a podcast and then creates the metadata object for every new episode to embed into the files. Since this was not intended, we return the "podcasts" metadata at the API level instead. The files still update correctly. ## How have you tested this? Podcasts from itunes ## Screenshots <img width="787" height="531" alt="grafik" src="https://github.com/user-attachments/assets/1f7a6a33-312e-4792-af63-902adcdb7851" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:10 +02:00
adam closed this issue 2026-04-25 00:19:10 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4295
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?