starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4565] [MERGED] Fix server crash when transcode requests are made to the direct play endpoint #4288

New Issue
Closed
opened 2026-04-25 00:19:09 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:09 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4565
Author: @advplyr
Created: 8/8/2025
Status: ✅ Merged
Merged: 8/8/2025
Merged by: @advplyr

Base: master ← Head: redirect_transcode_requests

📝 Commits (1)

  • 794f0ef Fix server crash when transcode requests are made to the direct play endpoint #4555

📊 Changes

1 file changed (+13 additions, -0 deletions)

View changed files

📝 server/controllers/SessionController.js (+13 -0)

📄 Description

Brief summary

Redirects HLS transcode requests being made to the direct play endpoint (/public/session/:id/track/:index) instead of the HLS endpoint (/hls/:stream/:file).

Also return 500 when audioFile has no path

Which issue is fixed?

Fixes #4555

In-depth Description

In android v0.10.0-beta a bug was introduced where transcodes are made to the direct play endpoint. This fixes that bug server side. It was fixed in the app here https://github.com/advplyr/audiobookshelf-app/pull/1636

How have you tested this?

Tested direct play in all clients and tested android transcodes redirect properly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4565 **Author:** [@advplyr](https://github.com/advplyr) **Created:** 8/8/2025 **Status:** ✅ Merged **Merged:** 8/8/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `redirect_transcode_requests` --- ### 📝 Commits (1) - [`794f0ef`](https://github.com/advplyr/audiobookshelf/commit/794f0ef42a12f30d300c03662e82318266d301d7) Fix server crash when transcode requests are made to the direct play endpoint #4555 ### 📊 Changes **1 file changed** (+13 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `server/controllers/SessionController.js` (+13 -0) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary Redirects HLS transcode requests being made to the direct play endpoint (`/public/session/:id/track/:index`) instead of the HLS endpoint (`/hls/:stream/:file`). Also return 500 when audioFile has no path ## Which issue is fixed? Fixes #4555 ## In-depth Description In android v0.10.0-beta a bug was introduced where transcodes are made to the direct play endpoint. This fixes that bug server side. It was fixed in the app here https://github.com/advplyr/audiobookshelf-app/pull/1636 ## How have you tested this? Tested direct play in all clients and tested android transcodes redirect properly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:09 +02:00
adam closed this issue 2026-04-25 00:19:09 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4288
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?