starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4551] [MERGED] Including total durations into the de-branding from #4226 as warning message is always present currently #4284

New Issue
Closed
opened 2026-04-25 00:19:08 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:08 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4551
Author: @chriscam85
Created: 8/1/2025
Status: ✅ Merged
Merged: 8/1/2025
Merged by: @advplyr

Base: master ← Head: master

📝 Commits (2)

  • e54571f Including total durations into the de-branding from #4226 as warning message is always present currently
  • 894ea0b Update chapter data log

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 client/pages/audiobook/_id/chapters.vue (+6 -1)

📄 Description

Brief summary

Issue #4226 introduced the ability to remove the audible branding when editing chapters. While it does this well for the chapters themselves, all other validations do not account for it. This update is to remove the branding times from the runtime totals as well.

Which issue is fixed?

Related to #4226

In-depth Description

Although the branding times are removed and the chapters are shifted, you will always receive the warning that the total time doesn't match you local audio files. This is because the #4226 feature didn't also remove the branding from the total runtime. This update also removes the intro/outro branding times from the total duration, which is used in the validation logic.

How have you tested this?

I did not test this. Not sure how.

Screenshots

The branding time in the example below is 6,873 millis, which results in the difference of 7 secs.
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4551 **Author:** [@chriscam85](https://github.com/chriscam85) **Created:** 8/1/2025 **Status:** ✅ Merged **Merged:** 8/1/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`e54571f`](https://github.com/advplyr/audiobookshelf/commit/e54571f011880b8cd8e9693eb952f9dc8e40fe40) Including total durations into the de-branding from #4226 as warning message is always present currently - [`894ea0b`](https://github.com/advplyr/audiobookshelf/commit/894ea0b80a8453999ab1290f03c5f47e05e1c362) Update chapter data log ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `client/pages/audiobook/_id/chapters.vue` (+6 -1) </details> ### 📄 Description ## Brief summary Issue #4226 introduced the ability to remove the audible branding when editing chapters. While it does this well for the chapters themselves, all other validations do not account for it. This update is to remove the branding times from the runtime totals as well. ## Which issue is fixed? Related to #4226 ## In-depth Description Although the branding times are removed and the chapters are shifted, you will always receive the warning that the total time doesn't match you local audio files. This is because the #4226 feature didn't also remove the branding from the total runtime. This update also removes the intro/outro branding times from the total duration, which is used in the validation logic. ## How have you tested this? I did not test this. Not sure how. ## Screenshots The branding time in the example below is 6,873 millis, which results in the difference of 7 secs. <img width="536" height="283" alt="image" src="https://github.com/user-attachments/assets/a1e2d507-7ab6-4fd4-9a60-3197b88e4438" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:08 +02:00
adam closed this issue 2026-04-25 00:19:08 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4284
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?