starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4546] [CLOSED] Fix EPUB.js CFI navigation bug #4279

New Issue
Closed
opened 2026-04-25 00:19:07 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:07 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4546
Author: @SFenton
Created: 7/30/2025
Status: ❌ Closed

Base: master ← Head: feature/epubjs-cfi-navigation-fix

📝 Commits (1)

  • a498fdf Fix EPUB.js CFI navigation bug

📊 Changes

2 files changed (+40 additions, -1 deletions)

View changed files

📝 client/package.json (+3 -1)
➕ client/patches/epubjs+0.3.93.patch (+37 -0)

📄 Description

  • Add patch-package to client dependencies
  • Add postinstall script to apply patches automatically
  • Add patch for EPUB.js v0.3.93 to fix CFI navigation
  • Changes scrollBy to scrollTo in continuous manager for proper absolute positioning
  • Fixes issue where CFI navigation loads content but target is outside viewport

This resolves CFI-based features like bookmarks, highlights, and reading position sync.

Brief summary

Which issue is fixed?

In-depth Description

How have you tested this?

Screenshots

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4546 **Author:** [@SFenton](https://github.com/SFenton) **Created:** 7/30/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature/epubjs-cfi-navigation-fix` --- ### 📝 Commits (1) - [`a498fdf`](https://github.com/advplyr/audiobookshelf/commit/a498fdf17d2e543b44d71637adcae668acce3194) Fix EPUB.js CFI navigation bug ### 📊 Changes **2 files changed** (+40 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `client/package.json` (+3 -1) ➕ `client/patches/epubjs+0.3.93.patch` (+37 -0) </details> ### 📄 Description - Add patch-package to client dependencies - Add postinstall script to apply patches automatically - Add patch for EPUB.js v0.3.93 to fix CFI navigation - Changes scrollBy to scrollTo in continuous manager for proper absolute positioning - Fixes issue where CFI navigation loads content but target is outside viewport This resolves CFI-based features like bookmarks, highlights, and reading position sync. <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary <!-- Please provide a brief summary of what your PR attempts to achieve. --> ## Which issue is fixed? <!-- Which issue number does this PR fix? Ex: "Fixes #1234" --> ## In-depth Description <!-- Describe your solution in more depth. How does it work? Why is this the best solution? Does it solve a problem that affects multiple users or is this an edge case for your setup? --> ## How have you tested this? <!-- Please describe in detail with reproducible steps how you tested your changes. --> ## Screenshots <!-- If your PR includes any changes to the web client, please include screenshots or a short video from before and after your changes. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:07 +02:00
adam closed this issue 2026-04-25 00:19:07 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4279
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?