starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4503] [MERGED] Update sessions modal to show username & update legacy token input with warning #4268

New Issue
Closed
opened 2026-04-25 00:19:04 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:04 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4503
Author: @advplyr
Created: 7/17/2025
Status: ✅ Merged
Merged: 7/17/2025
Merged by: @advplyr

Base: master ← Head: session_modal_user

📝 Commits (2)

  • 3845940 Add warning under legacy token input on users page to use api keys instead
  • e678fe6 Update sessions modal to show username & update sessions endpoints to always return username

📊 Changes

5 files changed (+27 additions, -14 deletions)

View changed files

📝 client/components/modals/ListeningSessionModal.vue (+4 -1)
📝 client/pages/config/users/_id/index.vue (+3 -1)
📝 client/strings/en-us.json (+1 -0)
📝 server/controllers/SessionController.js (+9 -11)
📝 server/controllers/UserController.js (+10 -1)

📄 Description

Brief summary

Sessions modal shows username instead of user id.

/api/sessions and /api/users/:id/listening-sessions endpoints always return a user object with sessions that includes id and username.

Adds a warning message under the legacy token input to use API Keys instead.

Which issue is fixed?

Fixes #4496

Screenshots

image image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4503 **Author:** [@advplyr](https://github.com/advplyr) **Created:** 7/17/2025 **Status:** ✅ Merged **Merged:** 7/17/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `session_modal_user` --- ### 📝 Commits (2) - [`3845940`](https://github.com/advplyr/audiobookshelf/commit/3845940245c3fd1311419d896a560d0482a77072) Add warning under legacy token input on users page to use api keys instead - [`e678fe6`](https://github.com/advplyr/audiobookshelf/commit/e678fe6e2f91d757f094373d46b26695cfd08e9a) Update sessions modal to show username & update sessions endpoints to always return username ### 📊 Changes **5 files changed** (+27 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `client/components/modals/ListeningSessionModal.vue` (+4 -1) 📝 `client/pages/config/users/_id/index.vue` (+3 -1) 📝 `client/strings/en-us.json` (+1 -0) 📝 `server/controllers/SessionController.js` (+9 -11) 📝 `server/controllers/UserController.js` (+10 -1) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary Sessions modal shows username instead of user id. `/api/sessions` and `/api/users/:id/listening-sessions` endpoints always return a user object with sessions that includes `id` and `username`. Adds a warning message under the legacy token input to use API Keys instead. ## Which issue is fixed? Fixes #4496 ## Screenshots <img width="946" height="633" alt="image" src="https://github.com/user-attachments/assets/0384bc89-62e0-4d81-ad91-b9128fdb5146" /> <img width="1208" height="319" alt="image" src="https://github.com/user-attachments/assets/1354d941-31e4-4190-85e2-29a6f17f007a" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:04 +02:00
adam closed this issue 2026-04-25 00:19:04 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4268
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?