starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4381] fix(Dockerfile): Wire ROUTER_BASE_PATH to build arg #4230

New Issue
Open
opened 2026-04-25 00:18:54 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:54 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4381
Author: @treyturner
Created: 6/6/2025
Status: 🔄 Open

Base: master ← Head: fix/wire-ROUTER_BASE_PATH-to-build-arg

📝 Commits (1)

  • 27a97f5 fix(Dockerfile): Wire ROUTER_BASE_PATH to build arg

📊 Changes

1 file changed (+9 additions, -0 deletions)

View changed files

📝 Dockerfile (+9 -0)

📄 Description

Brief summary

Create a clear interface for building an image with an empty or alternate ROUTER_BASE_PATH without needing to modify source, shell into containers, or rebuild at all.

Which issue is fixed?

Not sure if I'd consider this a fix per-se, but it may ease tension on sentiments along the lines of #3874

In-depth Description

The best I could make of the saga of this change given my available time is that if one desires a containerized instance of audiobookshelf with an empty ROUTER_BASE_PATH, they're responsible for building it themselves.

I haven't tested extensively yet as I'm still getting familiar with some of the features, but if I've understood the process recommended for doing so at present, it should work to set ROUTER_BASE_PATH empty before building the apps. I was surprised then to see then this variable wasn't wired up to a Docker build arg where it can be easily set from outside the build or containers without modifying the source:

docker build --build-arg ROUTER_BASE_PATH= . -t audiobookshelf:no_router_base_path

This PR was created both to ask the experts whether this is a complete and valid approach, and if so, offered as a small-diff pressure-release valve for people like myself who were initially flustered about the opinionated nature of this change.

How have you tested this?

I tested local and remote access via browser, the official Android app, and RSS feeds via PodcastAddict.

Screenshots

abs

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4381 **Author:** [@treyturner](https://github.com/treyturner) **Created:** 6/6/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix/wire-ROUTER_BASE_PATH-to-build-arg` --- ### 📝 Commits (1) - [`27a97f5`](https://github.com/advplyr/audiobookshelf/commit/27a97f50ece1325cbde5e59042eb92e602942c94) fix(Dockerfile): Wire ROUTER_BASE_PATH to build arg ### 📊 Changes **1 file changed** (+9 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+9 -0) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary Create a clear interface for building an image with an empty or alternate `ROUTER_BASE_PATH` without needing to modify source, shell into containers, or rebuild at all. ## Which issue is fixed? Not sure if I'd consider this a fix per-se, but it may ease tension on sentiments along the lines of #3874 ## In-depth Description The best I could make of the [saga of this change](https://github.com/advplyr/audiobookshelf/issues/3874#issuecomment-2614154863) given my available time is that if one desires a containerized instance of audiobookshelf with an empty `ROUTER_BASE_PATH`, they're responsible for building it themselves. I haven't tested extensively yet as I'm still getting familiar with some of the features, but if I've understood the process recommended for doing so at present, it should work to set `ROUTER_BASE_PATH` empty before building the apps. I was surprised then to see then this variable wasn't wired up to a Docker build arg where it can be easily set from outside the build or containers without modifying the source: ```sh docker build --build-arg ROUTER_BASE_PATH= . -t audiobookshelf:no_router_base_path ``` This PR was created both to ask the experts whether this is a complete and valid approach, and if so, offered as a small-diff pressure-release valve for people like myself who were initially flustered about the opinionated nature of this change. <!-- Describe your solution in more depth. How does it work? Why is this the best solution? Does it solve a problem that affects multiple users or is this an edge case for your setup? --> ## How have you tested this? I tested local and remote access via browser, the official Android app, and RSS feeds via PodcastAddict. ## Screenshots <img width="955" alt="abs" src="https://github.com/user-attachments/assets/51254142-6457-4113-aa21-bd06088b0e0f" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:54 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4230
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?