starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4374] [MERGED] Corrects removing of attachments for Trix #4229

New Issue
Closed
opened 2026-04-25 00:18:54 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:54 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4374
Author: @Vito0912
Created: 6/4/2025
Status: ✅ Merged
Merged: 6/4/2025
Merged by: @advplyr

Base: master ← Head: feat/allowBase64Images

📝 Commits (1)

📊 Changes

1 file changed (+2 additions, -4 deletions)

View changed files

📝 client/components/ui/VueTrix.vue (+2 -4)

📄 Description

Brief summary

Currently, files can be added to the editor, which I think is nice and could be brought back in the future. However, because the description is sanitized,(btw. ignore name of branch. Not possible because of sanitization). I noticed that files can be pasted, including images, so maybe we should consider allowing files in the future, but right now, sanitization removes them when the description is saved. To get parity now all attachments are disallowed, also including files

Maybe there's a reason we allowed files that I missed (in that case, please close this), but at the moment, you can add files (such as images or Excel files) that are just lost after saving.

Which issue is fixed?

None

In-depth Description

See description

How have you tested this?

Copy pasting images and files

Screenshots

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4374 **Author:** [@Vito0912](https://github.com/Vito0912) **Created:** 6/4/2025 **Status:** ✅ Merged **Merged:** 6/4/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `feat/allowBase64Images` --- ### 📝 Commits (1) - [`759c58d`](https://github.com/advplyr/audiobookshelf/commit/759c58d3f7561b6d56b61fa78ec6880f10796fa8) remove any attachment ### 📊 Changes **1 file changed** (+2 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `client/components/ui/VueTrix.vue` (+2 -4) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary Currently, files can be added to the editor, which I think is nice and could be brought back in the future. However, because the description is sanitized,(btw. ignore name of branch. Not possible because of sanitization). I noticed that files can be pasted, including images, so maybe we should consider allowing files in the future, but right now, sanitization removes them when the description is saved. To get parity now all attachments are disallowed, also including files Maybe there's a reason we allowed files that I missed (in that case, please close this), but at the moment, you can add files (such as images or Excel files) that are just lost after saving. ## Which issue is fixed? None ## In-depth Description See description ## How have you tested this? Copy pasting images and files ## Screenshots <!-- If your PR includes any changes to the web client, please include screenshots or a short video from before and after your changes. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:54 +02:00
adam closed this issue 2026-04-25 00:18:54 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4229
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?