starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4378] [MERGED] Notifications for failed rss feeds and disabled rss feeds #4228

New Issue
Closed
opened 2026-04-25 00:18:54 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:54 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4378
Author: @Vito0912
Created: 6/5/2025
Status: ✅ Merged
Merged: 6/9/2025
Merged by: @advplyr

Base: master ← Head: feat/PodcastNots

📝 Commits (5)

  • 6aa7c8a added notification
  • 346df36 local strings
  • f0525d4 abc is hard
  • 7122756 Update notification description grammar
  • 5e2bb0b Fix notification js docs and update description/defaults

📊 Changes

4 files changed (+84 additions, -0 deletions)

View changed files

📝 client/strings/en-us.json (+2 -0)
📝 server/managers/NotificationManager.js (+48 -0)
📝 server/managers/PodcastManager.js (+2 -0)
📝 server/utils/notifications.js (+32 -0)

📄 Description

Brief summary

Adds notifications for failed notifications and a separate type that triggers when an RSS feed is disabled because of this action.

Which issue is fixed?

None, but helps with https://github.com/advplyr/audiobookshelf/issues/4377 and while https://github.com/advplyr/audiobookshelf/pull/2178 is not merged this also gives a way to track disabled podcasts

In-depth Description

Code ^^

How have you tested this?

Setting timeout to a ms and using the testpayload

Screenshots

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4378 **Author:** [@Vito0912](https://github.com/Vito0912) **Created:** 6/5/2025 **Status:** ✅ Merged **Merged:** 6/9/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `feat/PodcastNots` --- ### 📝 Commits (5) - [`6aa7c8a`](https://github.com/advplyr/audiobookshelf/commit/6aa7c8a3d8734b55f932e8c270d830bc8644d36f) added notification - [`346df36`](https://github.com/advplyr/audiobookshelf/commit/346df3680ce8dd415ce3d77d5ce789686e8dd5f9) local strings - [`f0525d4`](https://github.com/advplyr/audiobookshelf/commit/f0525d4f0de8392b87d788fda3a0a6bda57d15c8) abc is hard - [`7122756`](https://github.com/advplyr/audiobookshelf/commit/7122756e585a2d4213f1af2a347f287d8b6e2473) Update notification description grammar - [`5e2bb0b`](https://github.com/advplyr/audiobookshelf/commit/5e2bb0b12ccacaca5d231e4a5a3bd9ffb111a9df) Fix notification js docs and update description/defaults ### 📊 Changes **4 files changed** (+84 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `client/strings/en-us.json` (+2 -0) 📝 `server/managers/NotificationManager.js` (+48 -0) 📝 `server/managers/PodcastManager.js` (+2 -0) 📝 `server/utils/notifications.js` (+32 -0) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary Adds notifications for failed notifications and a separate type that triggers when an RSS feed is disabled because of this action. ## Which issue is fixed? None, but helps with https://github.com/advplyr/audiobookshelf/issues/4377 and while https://github.com/advplyr/audiobookshelf/pull/2178 is not merged this also gives a way to track disabled podcasts ## In-depth Description Code ^^ ## How have you tested this? Setting timeout to a ms and using the testpayload ## Screenshots <!-- If your PR includes any changes to the web client, please include screenshots or a short video from before and after your changes. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:54 +02:00
adam closed this issue 2026-04-25 00:18:54 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4228
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?